Comments (4)
It would be really nice to be able to translate pages in iframes too. Probably easier to explore the iframes as DOM nodes yes
from linguist.
It require method to detect main CS and CS in iframe for same tab.
Primary must execute commands, and sub scripts must only listen and obey.
Also it require synchronization of singleton instances like button for translate selected text which should be shown only in one place - main page or iframe.
p.s. Use match_about_blank
for blank iframes: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_scripts
from linguist.
from linguist.
If we will enable this feature, we have to:
- Listen events for each contentscript instance on tab
- Calculate one state for all instances, to send responses on requests (like popup requests "what's page translation state?", "what's page language?")
- Exchange data between instances
We have to try find another way, like explore iframe as DOM node if possible, to keep only one contentscript instance
from linguist.
Related Issues (20)
- Not able to register Ctrl/Alt/Shift as keybindings when RFP on firefox is set to True HOT 4
- Open links from addon popup in a current tab
- Use alternative package instead of `convert-svg-to-png`
- Enable linter rule to require issue id in commit message
- Unusable slow translation with google translator HOT 1
- Can't run `npm run build:dev` with no build a thirdparty code
- Enable sentry to track errors with no user texts
- Apply changes on preferences page immediately
- Fix errors in console `DOMException: A mutation operation in the transaction failed because a constraint was not satisfied.`
- Cannot to open window to edit custom translator on android phone
- Some languages supported by custom translators are not displaying in the dropdown menu HOT 1
- Enhancement Request: Block-Level HTML Translation HOT 3
- Add the popup next to the marked text and not next to the mouse HOT 3
- Google translator return translated text and original both as translation for some cases HOT 2
- Option to show original text and translated both in one popup HOT 3
- Add more translators HOT 4
- Try the `knip` tool to find unused files in repository
- Call to action for rate extension in storages
- Button inside the pop-up to quickly copy to the clipboard HOT 1
- Update translators package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linguist.