tprobinson / prerender-s3-cache Goto Github PK

As brought up by PR #1, folders have less overhead compared to a flat cache.

We can't necessarily trust the URL that comes in is well-formatted, and allowing the URL to create its own slashes could lead to weirdness depending on how S3 handles things like adjacent slashes, dots, tildes, things like that. Plus, without sanitizing those other special characters that getCacheFormattedKey handles, we could run into other problems. So maybe it would be best to checksum the incoming URL with md5 or shax (and allow a selection of hashing algorithm), then divide it into a two or three-layer folder hierarchy using the hash.

As brought up by #1, region is a useful parameter to have.

Considering how many other parameters they have, and we don't necessarily want to handle defaults about it, it might be better to add an s3Options parameter to just apply directly to the S3 constructor.