Code Monkey home page Code Monkey logo

Comments (5)

smccutchen avatar smccutchen commented on August 26, 2024 2

I can confirm the config options available in 14.9 are working as expected.

Thanks for the fast effort!

from mail_room.

stanhu avatar stanhu commented on August 26, 2024

Is there a workaround for this, short of editing the file manually?

Not yet.

My trial Azure government tenant has expired. Would you be able to test out #140?

from mail_room.

smccutchen avatar smccutchen commented on August 26, 2024

I can confirm that it's fully functional once I manually modify the "connection.rb" file to use the correct endpoint URLs for GCC High - in my case it's "graph.microsoft.us" and "login.microsoftonline.us" .

Commit #140 looks great (exactly what we'd want) but I'm not sure how to test it within the context of GitLab (I suspect they'd need to do some changes on their end to also support this, since I pass my tenant id + client id through the gitlab.rb config file).

Either way, great work!

from mail_room.

stanhu avatar stanhu commented on August 26, 2024

Yeah, you'd need to replace connection.rb with that file and then manually edit /opt/gitlab/embedded/service/gitlab-rails/config/mail_room.yml with those options.

I'll see if I can get Microsoft to reactivate my Microsoft Government Cloud account in the interim.

from mail_room.

stanhu avatar stanhu commented on August 26, 2024

@smccutchen GitLab 14.9 shipped with the updated MailRoom that has the graph_endpoint and azure_ad_endpoint config options. Would you mind testing whether the documentation in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/83242/diffs is correct?

from mail_room.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.