Comments (8)
@DouweM Would you or someone else from GitLab like to weigh in on this?
from mail_room.
@cablett Would you like to weigh in on this? :)
from mail_room.
I'll take a look at this later this week or early next week. Thank you for pinging me, I'd be delighted to be part of this conversation. ✨
from mail_room.
I think my big question is: does adding this dependency make it distinctly harder for gitlab to use mail_room.
from mail_room.
Thank you for the clarification - this week got away on me. Do you have a timeline for this issue?
from mail_room.
No timeline, it just dovetails with #99 and my plan to use concurrent-ruby for that. In the case of 99 it would be optional, but I think adding it to the main project might provide some good cleanup for the start of a post-1.0 release.
from mail_room.
Looks like what I really want is the Actor
which a part of their "edge" library. Until it moves into stable, I could use Async
and get the async
and await
proxies. I might give that a spike just to see if it improves the code. If not, we can hold on this until Actor
becomes available in stable.
from mail_room.
I spiked out some changes, and while it let me maybe get rid of Coordinator
and MailboxWatcher
, I'm not really sure it would work. It was also much more difficult to test.
Fun experiment, but closing this for now.
from mail_room.
Related Issues (20)
- run tests against redis 4 - fails with TypeError: no implicit conversion of Symbol into Integer HOT 1
- Pulling some config from environment vars HOT 1
- Support for OAuth HOT 11
- Enable "Build pushed branches" in Travis CI HOT 4
- certificate verify failed HOT 1
- Support Azure Government tenants with Microsoft Graph HOT 5
- Console Log HOT 3
- Noisily fail when JWT can't be encoded HOT 4
- Why not publish 0.10.1 to rubygems.org? HOT 3
- Transactional SEEN/UNSEEN HOT 1
- Structured logging of message fetching and delivery HOT 3
- Possible race condition in mailbox_watcher.rb quit method - undefined method `join' for nil:NilClass HOT 2
- Update ruby version requirements, drop imap backport HOT 1
- Mailroom crash on lost connection to IMAP HOT 3
- Add docs/support for ActionMailbox HOT 6
- Arbitration locking issue HOT 4
- Need to call expunge() or close() sometime to delete messages HOT 6
- Allow log path to be configured to STDOUT/STDERR
- Add a Prometheus metrics endpoint HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mail_room.