tpg / attache Goto Github PK

Extract the Laravel specific stuff making Attache more generic and technology agnostic. Maybe look at a "driver" based approach where tasks for specific projects or frameworks could be leveraged.

PHP Fatal error: Uncaught TypeError: Argument 1 passed to TPG\Attache\ReleaseService::__construct() must be an instance of TPG\Attache\Server, null given, called in /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesPruneCommand.php on line 37 and defined in /Users/mac/.composer/vendor/thepublicgood/attache/src/ReleaseService.php:28
Stack trace:
#0 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesPruneCommand.php(37): TPG\Attache\ReleaseService->__construct(NULL)
#1 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/Command.php(111): TPG\Attache\Console\ReleasesPruneCommand->fire()
#2 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/DeployCommand.php(67): TPG\Attache\Console\Command->execute(Object(Symfony\Component\Console\Input\ArrayInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/Command.php(111): TPG\Attache\Console\DeployCommand->fire()
#4 /Users/mac/.composer/vendor/symfony/cons in /Users/mac/.composer/vendor/thepublicgood/attache/src/ReleaseService.php on line 28

Fatal error: Uncaught TypeError: Argument 1 passed to TPG\Attache\ReleaseService::__construct() must be an instance of TPG\Attache\Server, null given, called in /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesPruneCommand.php on line 37 and defined in /Users/mac/.composer/vendor/thepublicgood/attache/src/ReleaseService.php:28
Stack trace:
#0 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesPruneCommand.php(37): TPG\Attache\ReleaseService->__construct(NULL)
#1 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/Command.php(111): TPG\Attache\Console\ReleasesPruneCommand->fire()
#2 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/DeployCommand.php(67): TPG\Attache\Console\Command->execute(Object(Symfony\Component\Console\Input\ArrayInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/Command.php(111): TPG\Attache\Console\DeployCommand->fire()
#4 /Users/mac/.composer/vendor/symfony/cons in /Users/mac/.composer/vendor/thepublicgood/attache/src/ReleaseService.php on line 28

Issue seems to be with the --prune section of the command
works if you run attache deploy production then attache releases:prune production

attache deploy production --prune removing all releases except for live version, instead of live version plus previous version. This command also seems to break the site when I ssh into the server it won't let me navigate to the "live" folder it says this is not a directory I had to run attache deploy production without the --prune to get it to work again

The server configuration requires that server names are unique, so it makes sense to rather use the server name as an object key in the config. So

"servers": {
    "server-name": {
        "host": "server.example"
    }
}

Instead of servers being an array of objects.
This is breaking change. Maybe look at either keeping the current implements as well or providing a simple conversion tool.

If no default server is specified and there is more than one server in the config file, allow the server to be interactively selected.

Build a schema and use something like justinrainbow/json-schema to validate the config file.

Add a --branch option to the deploy command.

When I try to run attache releases:list on my project i get the error below

PHP Fatal error: Uncaught Error: Call to a member function format() on bool in /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php:129
Stack trace:
#0 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php(106): TPG\Attache\Console\ReleasesListCommand->releaseDate('initial')
#1 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php(83): TPG\Attache\Console\ReleasesListCommand->buildTable(Array, '20200330104330')
#2 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php(55): TPG\Attache\Console\ReleasesListCommand->showOutput(Array, '20200330104330')
#3 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/Command.php(111): TPG\Attache\Console\ReleasesListCommand->fire()
#4 /Users/mac/.composer/vendor/symfony/console/Command/Command.php(255): TPG\Attache\Console\Command->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#5 /Users/ in /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php on line 129

Fatal error: Uncaught Error: Call to a member function format() on bool in /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php:129
Stack trace:
#0 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php(106): TPG\Attache\Console\ReleasesListCommand->releaseDate('initial')
#1 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php(83): TPG\Attache\Console\ReleasesListCommand->buildTable(Array, '20200330104330')
#2 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php(55): TPG\Attache\Console\ReleasesListCommand->showOutput(Array, '20200330104330')
#3 /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/Command.php(111): TPG\Attache\Console\ReleasesListCommand->fire()
#4 /Users/mac/.composer/vendor/symfony/console/Command/Command.php(255): TPG\Attache\Console\Command->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#5 /Users/ in /Users/mac/.composer/vendor/thepublicgood/attache/src/Console/ReleasesListCommand.php on line 129