towa-digital / towa-gdpr-plugin Goto Github PK

https://github.com/szepeviktor/phpcs-psr-12-neutron-hybrid-ruleset

Here I’m trying to gain benefits of

• livable and readable PSR-12
• Automattic’s Neutron power 😀
• and static analysis from WPCS
• Slevomat 🚀 rules

Was https://bitbucket.org/towa_gmbh/towa-gdpr-plugin/issues/3/modern-coding-standard

Currently we have surrogates for almost every commiter:

• one with company email
• one with private emails

It is beneficial to use only one.
Please consider deciding it.

Hanging PR: https://bitbucket.org/towa_gmbh/towa-gdpr-plugin/pull-requests/20/style-commits-added-commitlinting/diff

Please consider putting only source code in the repo.

A build process could handle the plugin release: run tests and build all part, e.g. compile SASS to CSS

Was https://bitbucket.org/towa_gmbh/towa-gdpr-plugin/issues/2/generated-code-in-the-repo
@Martin-Welte

Describe the bug
In internet explorer 11 the toggle group button opens/closes the accordion as well.

To Reproduce

• Use IE 11
• toggle cookie group

Expected behavior
Only the group should be activated/deactivated and the accordion functionality only controlled via the open/close button

Desktop:

• IE 11

Hello guys!

Have you put development on hold?
Should I use another GDPR plugin?

Describe the bug
If the Wpml multilingual plugin is active there is no synchronisation of the hash between languages.
Because of that the cookie notice gets displayed everytime the user changes the language (as every language has a different hash and the local browser cookie gets overwritten with this specific hash for the active language)

To Reproduce

1. Go to a website that uses towa-gdpr-plugin in sitepress-multilingual-cms
2. Change between languages -> you have to accept the cookies every time you change the language

Expected behavior
As a User I want to accept the cookie notice once and not every time I change the language.
As an Admin I want to synchronise the hash between languages (possible fix: make the acf hash field editable and enable manual synchronisation between languages with that - copy paste between languages)

Desktop

• OS: independent
• Browser independent
• Version v1.1.8

Smartphone

• Device: independent
• OS: independent
• Browser independent
• Version v1.1.8