tootallnate / node-get-uri Goto Github PK

WARNING Compiled with 1 warnings 08:32:26

warning in ./node_modules/get-uri/index.js

Critical dependency: the request of a dependency is an expression

It seems to me it also should be updated for Azure/autorest#2416

Issue have been fixed here: TooTallNate/file-uri-to-path#5

node-ftp seems very outdated... no update for 4-5 years
how about switching client to something new? like basic-ftp or something else?

Unhandled 'error' event in ftp.js, for example 'Error: socket hang up'

maybe should add this
client.once('error', onerror);

disregard please

Using mailgun-js which uses this package which breaks a fairly fundemental rule; Don't use expressions as dependencies.

It causes tools like Webpack to throw up, trying to include every last file in your package.

https://github.com/TooTallNate/node-get-uri/blob/master/index.js#L29

I've not looked into why this is used, but please consider changing it.

See mscdex/node-ftp#255

Hey there!

I belong to an open source security research community, and a member (@Sampaguitas) has found an issue, but doesn’t know the best way to disclose it.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)

Would you be interested in a pull-request for an S3 protocol handler that accepts URLs of the form s3://bucket/path/to/key? I wrote one for an application we're building. It works well, but I haven't yet implemented a cache option. Because the aws-sdk node package is somewhat large, I'd suggest only conditionally importing the s3 protocol if the aws-sdk is available.

FTP paths not working if it contains the space symbol. It's converted to HTTP protocol format (%20), which not supported(?) by FTP standard.

I think the FTP paths shouldn't be escaped at all.

Temporary fix in ftp.js:27:

var filepath = unescape(parsed.pathname);

Some day, when parsing Windows file: URI paths is more important, we might want to refactor the url.parse() call into something more advanced like:

https://github.com/mono/mono/blob/master/mcs/class/System/System/Uri.cs

(probably write a uri-parse component or something)

If you request an HTTP url and it redirects to HTTPS, you get the following error:

Error: Protocol "https:" not supported. Expected "http:"
    at new ClientRequest (_http_client.js:131:11)
    at request (http.js:38:10)
    at Object.get (http.js:42:13)

Example URL: http://img.shields.io/npm/v/react-markdown.svg?style=flat-square

because it looks really cool...

Hi just wanted to let you know that going into version 2.0.3 you've updated major versions of your dependencies without incrementing your own major version number.

This means that those maintaining legacy code on node <=5 will probably hit issues with block scoped variables amongst other things the next time they update any modules that depend, anywhere in the dependency chain, on this module.

even though this is get-uri, would it be too far outside its scope to return readable.streams on other HTTP methods, namely POST?

Would you be open to review another pull that lets us pass the method as an option when calling the function for that protocol? something like:

opts = {

method: 'post',
...

and this time I would definitely git rebase my fork before sending the pull...

It seems an empty options object is required to use async/await:

// Invalid
const stream = await getUri(uri);
// Valid
const stream = await getUri(uri, {});

TypeScript won't compile the first version.