Code Monkey home page Code Monkey logo

Comments (3)

teadrinker avatar teadrinker commented on June 9, 2024

The Blend operator causes odd behavior due to GetTextureSize being used in a way so that it only cares about one of the input images:

T3Editor_24-03-21__11-57-06

from t3.

teadrinker avatar teadrinker commented on June 9, 2024

It's tempting to try to use context.RequestedResolution (like the new SetRequestedResolution), however I see 2 problems with this approach:

  • Result cache system would need to be more complex (dirty-flag per requested resolution or no cache support for updateActions when resolution is different)
  • I feel isolated resolution override is a different use case from what SetRequestedResolution offers, and offering the latter as a solution to the former would cause confusing behaviour (resolution override that transcends operator boundaries would have unintended consequences etc)

from t3.

pixtur avatar pixtur commented on June 9, 2024

Thanks for the feedback. You're correct in that ideally all ops using [GetTextureSize] should publish this parameter to allow an override. In practice, I have to admit, I'm hesitant to implement everything that would be consistent because I'm afraid that that many operators would suffer from too many parameters. Also there is a small performance overhead by the added parameter.

On the other hand, I recently stumbled over the same issue. So I added [SetRequestedResultion] after our discussion on discord.

from t3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.