toolchainz / jingle Goto Github PK

Right now we have ModeledBlock (a modeled basic block) and ModeledInstruction (a single instruction) as two similar, but distinct types. ModeledBlock has the extra constraint that it will only be constructed if the block terminates in non-fallthrough branches.

This isn't ideal for a few situations:

• This isn't really guaranteed to be a basic block in the program graph, so it's less useful for actual analysis
• If you want a function to be more generally usable, you pay the price with a bunch of noisy trait bounds; often things just don't bother and choose one.
• This is confusing

Should consider removing this separation and just calling it what it is: a trace of pcode operations. A single trace structure could represent an instruction or our poor-man's basic block. Could also implement Add and friends on it to allow easily manipulating traces.

We should definitely have something for basic blocks eventually, but that will require a more thorough treatment of the program graph. And maybe we can just piggy-back on some of the higher analysis that sleigh performs.

Hi! Do you think it would be beneficial to move jingle_sleigh into a separate crate? This way, people who only need the pcode bindings would not have to add unused libraries to their projects

Hi! Thank you for the nice bindings. Would it be possible to add a static-link-z3 feature to z3-sys, so that users don't need to manually install z3-dev on their systems to access z3.h?

This is currently blocked.

In Ghidra 11.1, sleigh was updated to support compressed architecture modules. This feature brings along a mandatory dependency on zlib.

So, to update, need to either:

• Add a build.rs step that ensures zlib is installed and adds it to the linking path
• Vendor it in with the other C++ and use the "local zlib" build option.
• Maybe there's a way to do option 2 but link it to libz-sys instead