From @Geo1088 on August 23, 2017 14:17

Biggest visible issue with the style now is the new site relies on box-sizing: border-box; a lot, and toolbox's elements all assume box-sizing: content-box; instead. In general things need to be updated to adapt to the new CSS.

Copied from original issue: eritbh/reddit-moderator-toolbox#5

Annoying me because it opens up on page load and takes a second to collapse. The show/hide behavior can be done just with CSS transitions, so I'll look into doing it that way.

Also, on a slightly related note, there should be no left border on that menu since it butts up against the left side of the screen. It and the modbar handle should also be the same size as the bottombar handle when collapsed, preferably.

New API feature allows one to view dismissed reports. It is an attribute of posts and comments that have dismissed reports. Only really has use on old reddit, and would be a major improvement.

Example:

user_reports_dismissed":[
   [
      "!!!!!!!!",
      1
   ],
   [
      "n-notice me mod-senpai",
      1
   ],
   [
      "Super retarded.",
      1
   ],
   [
      "Open borders for /r/drama and Israel!",
      1
   ],
   [
      "why would you do this?",
      1
   ],
   [
      "go back private ugh",
      1
   ]
]

Related to #44

fetch is supported on all relevant browser versions and has a much nicer API than $.ajax does.

Because $.ajax passes three parameters to its callbacks, it's more difficult to have it play well with promises, which can only represent a single value (we get around this now by promising an object with the callback values as properties, but this isn't ideal). fetch, on the other hand, promises a single Response object.

Additionally, Response is (relatively) easily serializable to/from JSON - e.g. we can get the response from the background page, convert it to JSON, and then let TBUtils.sendRequest convert the JSON it received from the background page back into a Response object with its constructor. For example:

// background script
browser.runtime.onMessage.addListener(async request => {
    const response = await fetch('...');
    const headers = {};
    for (const [k, v] of response.headers) {
        headers[k] = v;
    }
    return [response.text(), {
        status: response.status,
        statusText: response.statusText,
        headers,
    }];
});
// content script
const response = await browser.runtime.sendMessage({...}).then(responseData => new Response(...responseData));
doSomethingWith(response.json());

Something like this https://codepen.io/anon/pen/zMReBz

From @creesch on November 13, 2017 21:7

Basically there a few instances where TBUtils.baseDomain is used that makes it so people navigate away from the redesign alpha. Those instances need to be replaced by TBUtils.tempBaseDomain eritbh/reddit-moderator-toolbox@0be5240 so this doesn't happen. Once the alpha is over we simply replace these temp instances and go on our way.

TODO:

• queue notifications
• queue counters in modbar

Future TODO:

• Message notifications
• Other modbar counters

Copied from original issue: eritbh/reddit-moderator-toolbox#8

Specifically if the second one to be deleted sat below the first one, this is caused by key references not being updated when a reason is removed.

https://github.com/toolbox-team/reddit-moderator-toolbox-redesign/blob/master/extension/data/modules/config.js#L1073

We probably want to make a seperate set of pages for now and make sure the questionmark from settings leads to there.

Currently new modmail is the odd one out that basically does a bit of a hybrid thing between old reddit and new reddit. We probably want to integrate it more into the new reddit jsAPI event flow so relevant buttons are easier to implement in new modmail as well.

Prompted today with me wanting to use the toolbox profile feature in modmail and finding out that we don't have any way to trigger it there. Which is very silly of course.

https://github.com/toolbox-team/reddit-moderator-toolbox-redesign/blob/master/extension/data/background/background.js#L54

It would be annoying if it decides to open the tab in a background window.

https://www.reddit.com/r/tb_redesign/comments/8oy3pp/bug_comment_nuke_adds_a_new_button_every_time_a/

#819

Will probably use some type of border style since we already use background styles for the percentage indicators. I'll likely reorganize some of the styling for this module in the same commit since using inline style attributes for this too would be hacky.

Something like what RES has

It's not something that high priority, but it does make changing settings faster

From @creesch on August 22, 2017 20:11

Initially we cannot escape some hacky stuff to get it to work on the new.reddit subdomain. Obviously this will need to be fixed at a later date. This issue attempts to keep track of those instances.

• tbmodule.js https://github.com/toolbox-team/reddit-moderator-toolbox-redesign/blob/master/extension/data/tbmodule.js#L385

  if (TB.storage.domain !== 'new' && TB.storage.domain !== 'www') {

• tbutils.js https://github.com/toolbox-team/reddit-moderator-toolbox-redesign/blob/master/extension/data/tbutils.js#L63

  TBUtils.tempBaseDomain = window.location.hostname === 'new.reddit.com' ? 'https://new.reddit.com' : 'https://www.reddit.com';

Copied from original issue: eritbh/reddit-moderator-toolbox#1

This is gets cluttered fast, even more so if we start adding metrics as well.

This would be sort of an solution but isn't ideal since it might be entirely unclear for the user that there is a dropdown under notes.

This issue needs to be resolved before we tackle #650

this breaks the counter. Luckily the solution is simple, move the request to a background page. I simply need to implement this.

This would allow us to move old reddit functionality in newer modules. I am specifically thinking about

• queuetools
• comments

As this greatly simplifies settings migration as old settings will be present in the new module with the same name.

"Old" and new toolbox will be running side by side and this is fine when confronted for most of the website as the old one will only activate on the old tech stack and the new one only on the new one. With the exception of new modmail.

Ideally when both toolbox versions are installed the new one will handle new modmail, but this requires the old one to not activate. I am thinking of getting the new toolbox version to write a key to localstorage on activation which can be used by old toolbox as an indicator to simply not activate. An alternative would simply be a class on the body.

This obviously requires a change in the old toolbox codebase as well. It needs to hold of activating on new modmail for a little bit in order to make it so V4 has already written the needed info.

When you have a vertical bar | at the end (or near the end) of a removal reason's text, it will cause the following removal reasons to appear inside the removal reason, like a nested removal reason.

1. Have a removal reason's text end with |
2. Create removal reasons below that specific removal reason
3. Try remove with the first reason and you will have checkboxes for the following removal reasons

Due to how toolbox storage works we at some point decided to only check for notifications when on the "main" subdomain which was www. This worked fine when we only had to deal with np and language subdomains but became a bit of an issue when mod was introduced. However usually when someone has mod open they also have regular reddit open so updates to the counters would trickle through anyway.

With two toolbox versions things start to become complicated. If someone has both installed but basically only uses legacy the counters in modmail will never get updated.

This line of code is currently the problem

So what I want to do in order (and time available) is:

1. Quick fix: if toolbox is open in the mod domain check if other reddit tabs are open with the same toolbox version and if that isn't the case make toolbox check on that domain anyway.
2. Move the code that checks for updates and such to the background page and make each tab a consumer.
   • It might be a good idea to split background scripts and also make a backgroundUtils.js.
3. Not sure if we can separate this from point 2, move notification code to the background page as well.

From @creesch on August 23, 2017 16:59

Context: eritbh/reddit-moderator-toolbox#2 (comment)

One thing that this doesn't (yet) do is information handling, I talked about it a bit on irc yesterday where I floated the idea of creating a toolbox wrapper in the container where the data is also kept. I'd like your thoughts about that.

So tblistener would receive the below data

{
	"className": "s4tft2m-2 dQciYQ",
	"type": "postAuthor",
	"data": {
		"author": "creesch",
		"score": 49,
		"voteState": 1
	}
}

And then in the container create something like

<span class="tb-container-wrapper"  data-type="postAuthor" data-author="creesch" data-score="49" data-votestate="1"></span>

Before passing on the event so that modules have the wrapper to do their things in and already have the data stored for other future usage.

The pro side of this is that you don't need each module to handle this for their own use case and that it allows a sort of 'safe haven' for toolbox elements where interference by RES and other extensions is less likely.

A possible con is that we will not need to act on each container, handling like this does write to the DOM on every event we receive though possibly impacting performance negatively.

Copied from original issue: eritbh/reddit-moderator-toolbox#6

I remove a thread, and that's it, the thread gets removed. It should pop the removal dialog up, but for now I have to go into the thread manually and add the removal reason through a comment using the "add a removal reason" button.

Hopefully I'm not missing a setting here that makes that happen.

From @creesch on May 15, 2014 11:8

Basically says it in the title. Allow words to be only highlighted in specific subreddits.

Copied from original issue: #163

• https://www.reddit.com/r/tb_redesign/comments/7yjquv/how_to_fix_the_save_failed_error_on_chrome/

• Also possibly related

  • https://www.reddit.com/r/tb_redesign/comments/7px07y/error_trying_to_ban_user_from_mod_tools_button/
  • https://www.reddit.com/r/tb_redesign/comments/7y45hz/unable_to_ban_users_using_toolbox/
  • https://www.reddit.com/r/tb_redesign/comments/7px07y/error_trying_to_ban_user_from_mod_tools_button/

Have not been able to reproduce but suspect it might have to do with permanently being opted in.

https://www.reddit.com/r/tb_redesign/comments/86a2nz/bug_cannot_close_notes/

Probably just need to check that the positioning top value isn't negative in tbUI.

• Double usernote buttons in the sidebar sometimes.
• The popup misses the correct user context and shows up empty.
• It appears we no longer show usernotes next to people in the conversation (this might be due to something I changed semi intentionally but probably isn't something people will like)

What the title says, gulp modules are maintained poorly and it is overly complicated to do it through the gulp flow while we only do some fairly basic stuff anyway.

Seems to me that a simple npm script is easier to maintain.

Before we even attempt to submit to AMO.

We make use of DOMPurify which is accessed through TBui.purify and we basically need to purify most places were we generate html if we want to be safe. But certainly where we use "outside" data like from the api which is still almost all the things.

In order to do that we need to make sure that

• Nowhere we rely on attribute activated events (onclick="") as those will be removed by purify.
• Make sure we don't rely on other stuff being scrubbed out.

This will require serious compatibility testing.

It is turned off now as we don't have a proper place to hook it into the jsAPI but in modmail people probably want it anyway.

Firefox implements a promise-based version of Chrome's chrome.* extension API, referenced as browser.*: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API

It also provides a polyfill to support Chrome: https://github.com/mozilla/webextension-polyfill

Given we're converting lots of our code to promises, I think it would make sense to use a promise-based browser API since it doesn't seem like it's otherwise much different (shouldn't require much logic rewriting, just cleanup).

Feature Request:

I'm in the process of adding keyboard support for common mod actions in RES on a per-comment/post basis in the modqueue, such as [remove], [approve], but also [context]. For the context option, I've bound the key-press to fire a click event on the context link, so if the user has toolbox's context popup enabled, a key-press opens the popup.

My issue is that there appears to be no way to close the context popup from the keyboard. Is it possible to add an event listener to close the popup on Esc keyDown? I don't mind making the changes, but I'd like to know how it should be handled. Should an Esc keyDown close ALL open popups (e.g. if a context and usernotes popup is up), the most recently created popup, or something else?

I'm thinking it makes the most sense to add a 'keyDown' listener to $('body') which then fires a 'click' event on every link matching $('.mod-toolbox .tb-popup .tb-popup-header .buttons a.close'). So pressing Esc would close out every TBui popup.

Reddit Thread:

https://www.reddit.com/r/toolbox/comments/6v20yg/feature_request_close_popup_with_esc_key/

This was requested in /r/toolbox here and here.

The "Send removal reasons as subreddit" setting currently warns "Note: these will appear in modmail and potentially clutter it up.", which feature would help avoid.

A couple questions:

• Is it possible to enforce this setting (and the send as sub setting) for all mods in a subreddit?
• If a subreddit is still using the old mod mail, is it better to have this setting be a noop or to hit the /archive endpoint anyway? The endpoint returns 404 if the conversationId is invalid.
• Does toolbox currently contain any util for determining if a subreddit is on the new mod mail? (Aside from checking for the mod.reddit.com hostname, which only works when the user is checking modmail)

I'm happy to open a PR for this feature.

From @creesch on November 13, 2017 21:15

Currently modmatrix fetches the possible actions from the dropdown in the menu which also makes it possible to grab the icons from the current reddit css. This will likely not be possible in the future.

Ideally we get the admins to include something in the front-end api but if that is not possible we have to put the list of possible actions somewhere in the code where we can easily maintain it and make the code robust enough to handle actions it doesn't know.

Copied from original issue: eritbh/reddit-moderator-toolbox#9

Currently all settings that ever have been are still around if someone upgrades. Same goes for settings import as it simply imports all settings without checking if the setting does exist.

I think we likely can automatically do this as TB.module keeps track of each setting per module. That still leaves us with a bunch of settings that are not registered

TODO:

• Figure out if TB.module can easily be used for this.
• Figure out if any settings are being used that are not registered on a module level.
• Build clean up code for after people have upgraded.

TODO2:

• Figure out if we also want to do this on settings import.

The current implementation works most of the time but not always, some people have reported the creature staying on page until they change queue etc.

When you have queuetools, groupCommentsOnModPage setting enabled and you change the sort within a queue, the hr lines will be moved to the bottom of the page.

1. Enable groupCommentsOnModPage
2. Go to unmoderated or modqueue
3. Change the sort to one that changes the order
4. Scroll to the bottom and observe a stack of <hr>-elements

https://www.reddit.com/r/tb_redesign/comments/7zepnb/clicking_show_recent_actions_opens_comment_modal/

This happens in all browsers.

From @creesch on December 4, 2017 6:52

The current icons belong to old reddit and don't really fit in new reddit. Probably also a good time to consider using a font based icon set so we don't have to mess with base64 blobs.

• Modbar icons
• Icon links in modsubs popup
• Buttons for manipulating lists/tables in the settings window (e.g. shortcuts list)
• Various places in the subreddit config dialog
• A whole ton of other stuff

Copied from original issue: eritbh/reddit-moderator-toolbox#12

Currently it doesn't fit anymore resulting in an ugly mess. Possible solution is to not display the table inline but absolute relative to the container.

To reproduce:

1. Have the new modmail as your only reddit tab open
2. Wait for, or generate, a new modqueue item
3. Click the "New modqueue item" notification
4. The link goes to https://mod.reddit.com/r/mod/about/modqueue, which is a 404 error.

I found this on Firefox. I don't know if it applies to other kinds of notification.

Since we're assuming ES6 now, we can make this easier on ourselves:

• $.each(arr, (i, val) => {}) becomes arr.each((val, i) => {})
• $.inArray(thing, arr) !== -1 becomes arr.includes(thing)
• $.inArray(thing, arr) becomes arr.indexOf(thing)

It seems to hit a check where a text is required.

It would be awesome if there was an option to list additional wiki paths that the syntax highlighter should work on. I'm planning to put some script/bot configuration in there, and being able to make certain pages be opened with the syntax highlighting editor would be super neat.

For bonus points, ability to select type (yaml, json, css, etc) for each path, and maybe having wildcard paths.

Probably just add checkbox for each instance where if none are checked it will assume it needs to show on all.
Can probably be added without a schema change if we add it like that.

I want to build this as a redesign module simply because of the effort involved and it allows us to use some of the things old toolbox does not have.

Some considerations:

• Have it trigger jsAPI functions to include toolbox userhistory, usernotes and modbutton.
• For comments show the body by default.
• We might want to look into storing the modlog in IndexedDB when the search is running and us that as a future cache. This is however not without issues as we might have an incomplete version of the modlog in the local database.

Ya know, the silver premium and whatnot sillystuff.

I have not tried to reproduce this, but this seems like a weird error.

Toolbox v4.0.15 (beta) "new narwhal"
Chrome v65.0.3325.181 on macOS

Not sure if we messed up with the css or if the method we used to place a block on the bottom of reddit no longer works. Anyway, the tb-footer-block needs to be fixed.