tonarino / webrtc-audio-processing Goto Github PK

View Code? Open in Web Editor NEW

248.0 248.0 26.0 92 KB

Rust bindings for the webrtc-audio-processing library

License: BSD 3-Clause "New" or "Revised" License

Rust 70.71% C++ 29.29%

webrtc-audio-processing's People

Contributors

Stargazers

Watchers

webrtc-audio-processing's Issues

Links dynamically to libwebrtc_audio_processing despite "bundled" flag.

Whether bundled is set or not, the dylib link type is set for libwebrtc_audio_processing.

Question: Is it possible to call `process_render_frame` multiple times for different streams?

In a multi-peer voice call, you want to cancel echo from all streams. There is two ways:

mix the output, then call processor.process_render_frame once
call it multiple times on each tick per output stream

Which one is advised?

Make build errors more obvious

When using the "bundled" feature flag, we build webrtc-audio-processing from source.

However, if you're missing a tool like autotools or libtoolize, you get an unhelpful:

error: failed to run custom build command for `webrtc-audio-processing-sys v0.3.0`
Caused by:
  process didn't exit successfully: `$PROJECT/target/release/build/webrtc-audio-processing-sys-7c56c0aca102fa66/build-script-build` (exit code: 1)
--- stderr
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }

We can add nicer expect messages in build.rs to improve this.

Transient noise suppression seems to not work

(I'm using the new version from #23)

I tried enabling transient noise canceller to avoid keyboard noise, but it doesn't have any effect on the sound. Do you have any idea what should I expect and if it's indeed a bug or not?

Here's my config:

    let config = webrtc_audio_processing::Config {
      echo_canceller: EchoCanceller::Full {
        enforce_high_pass_filtering: true,
      }
      .into(),

      reporting: webrtc_audio_processing::ReportingConfig {
        enable_voice_detection: true,
        enable_residual_echo_detector: false,
        enable_level_estimation: false,
      },

      enable_transient_suppression: true,
      high_pass_filter: Some(webrtc_audio_processing::HighPassFilter {
        apply_in_full_band: true,
      }),

      pre_amplifier: Some(webrtc_audio_processing::PreAmplifier {
        ..Default::default()
      }),

      noise_suppression: Some(NoiseSuppression {
        level: noise_cancel_level, // low was lower than libwebrtc
        analyze_linear_aec_output: false,
      }),

      gain_controller: Some(GainController {
        ..Default::default()
      }),

      pipeline: Pipeline {
        maximum_internal_processing_rate:
          webrtc_audio_processing::PipelineProcessingRate::Max48000Hz,
        multi_channel_capture: true,
        multi_channel_render: true,
      },

      ..webrtc_audio_processing::Config::default()
    };

windows build

I'm having a bit of issues building on windows - autoconf / autotools do not exist, is there a workaround or someone who has built and used it successfully on windows?

0.1.2 didn't include submodule

Noticed it because docs.rs failed.
https://docs.rs/crate/webrtc-audio-processing-sys/0.1.3/builds/216263

Add CMakeLists.txt for this project c packge

cmake_minimum_required(VERSION 2.8)
project("webrtc-audio-processing" C CXX)
add_definitions(-D__STDC_FORMAT_MACROS)

set(CMAKE_BUILD_TYPE "DEBUG")#"RELEASE")

set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g")#-O2")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g")#-O2")
set(HOME_BASE "./")
add_definitions(-DWEBRTC_LINUX -DWEBRTC_POSIX -DWEBRTC_AUDIO_PROCESSING_ONLY_BUILD)
set(HAVE_NEON True)
set(HAVE_MIPS True)
# set(HAVE_X86 True)
set(NS_FIXED True)
set(WIN True)
# set(HAVE_ARM True)
# set(HAVE_ARMV7 True)
# set(HAVE_NEON True)
# # 头文件目录
include_directories(${HOME_BASE}/webrtc-audio-processing-sys/webrtc-audio-processing)
include_directories(${HOME_BASE}/webrtc-audio-processing-sys/webrtc-audio-processing)
include_directories(${HOME_BASE}/webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/include)

# 发现目录下的源文件

aux_source_directory(./webrtc-audio-processing-sys/src DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/base DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/resampler DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/vad DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_coding/codecs/isac/main/source DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aecm DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/agc DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/agc/legacy DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/beamformer DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/intelligibility DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/logging DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/transient DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/utility DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/vad DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing DIR_SRCS)
aux_source_directory(./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source DIR_SRCS)
include(utils.cmake)
# 排除不参与编译的文件

if(HAVE_NEON)
	
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/fir_filter_neon.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/resampler/sinc_resampler_neon.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/cross_correlation_neon.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/downsample_fast_neon.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/min_max_operations_neon.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/fir_filter_neon.h")
	
endif()
if(HAVE_MIPS)
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/complex_bit_reverse_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/complex_fft_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/cross_correlation_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/downsample_fast_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/filter_ar_fast_q12_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/min_max_operations_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/resample_by_2_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/spl_sqrt_floor_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/common_audio/signal_processing/vector_scaling_operations_mips.c")

endif()
if (NS_FIXED)
    add_definitions(-DWEBRTC_NS_FIXED=1)

    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/noise_suppression_x.h")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/noise_suppression_x.c")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/nsx_defines.h")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/nsx_core.c")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/nsx_core.h")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/nsx_core_c.c")
 
    if (!HAVE_NEON)

    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/nsx_core_neon.c")

    endif()
else()
    add_definitions(-DWEBRTC_NS_FLOAT=1)

    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/noise_suppression.h")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/noise_suppression.c")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/defines.h")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/ns_core.c")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/ns_core.h")
    list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/windows_private.h")

endif()

if (HAVE_X86)

list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_core_sse2.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_rdft_sse2.c")

    set(OS_FLAGS -msse2)
endif()

if (HAVE_NEON)

list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_core_neon.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_rdft_neon.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aecm/aecm_core_neon.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/nsx_core_neon.c")

endif()

if(HAVE_MIPS)

list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_core_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_rdft_neon.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aecm/aecm_core_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/ns/nsx_core_mips.c")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_rdft_mips.c")
# webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/modules/audio_processing/aec/aec_rdft_mips.c

endif()
if(WIN)
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source/condition_variable_native_win.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source/critical_section_win.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source/condition_variable_event_win.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source/event_timer_win.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source/rw_lock_win.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source/thread_win.cc")
list(REMOVE_ITEM DIR_SRCS "./webrtc-audio-processing-sys/webrtc-audio-processing/webrtc/system_wrappers/source/trace_win.cc")
endif()
add_library(libWebrtcapms STATIC ${DIR_SRCS})

iDS camera shows repeated errors of code=178

Happening at Stralight Tokyo Portal.

Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:51 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:51  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Error code: 178, count: 1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Camera capture encountered errors: total_errors=1
Feb 20 14:37:52 straylight-tokyo3c-portal tonari[31062]: 2020-02-20T14:37:52  ueye WARN   Error code: 178, count: 1

Stats should be made into an idiomatic Rust struct and publicly exported

Currently if we call get_stats, it returns a Stats struct from the webrtc-audio-processing-sys crate, but instead we should export a more Rust-y version from the the top-level webrtc-audio-processing crate.

https://docs.rs/webrtc-audio-processing/0.1.1/webrtc_audio_processing/struct.Processor.html#method.get_stats

API improvement: consider a split() function

Similar to how tokio's TCP stream has a split function to give read and write halves, it would be nice to have the same for the audio processor, where split() would give you a CaptureProcessor and a RenderProcessor. This could make the API a little easier to use when you're not using a duplex audio stream, as then you wouldn't need to put the processor in an Arc<Mutex<_>>

Fix linked C symbols on old macOS versions

I've compiled webrtc-audio-processing from build machine being Apple M1. It runs fine on the build machine (macOS Ventura). But when running on host x86_64-darwin-apple with an older version of macOS (Big Sur) it crashes with the Missing symbol error.

I believe it can be fixed with a similar patch:
h4llow3En/mac-notification-sys@1944fb3

Going to test this solution tomorrow at the office where I have the older Mac and report back.
Are you open to a PR for this?

What's blocking using latest freedesktop/pulseaudio-webrtc-audio-processing?

I see #23 but unsure what happened afterwards. Is there anything I can do to unblock having latest code for the AudioProcessing in?

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.