tompazourek / naturalsort.extension Goto Github PK

In v2.2.0, this comparison appears to get stuck in an infinite loop whereas v2.1.0 handles it without any problems.

StringComparer.OrdinalIgnoreCase.WithNaturalSort().Compare("abc", "Abc")

The following list of files ordered by name in Windows explorer:

1.txt
1a.txt
2.txt
11.txt
a.txt
a1.txt
a2.txt
a11.txt
aa.txt
b.txt
ba.txt
bb.txt

Are sorted differently with NaturalSort.Extension:

1.txt
1a.txt
2.txt
11.txt
a1.txt
a2.txt
a11.txt
a.txt <- Wrong position
aa.txt
b.txt
ba.txt
bb.txt

Tested with NaturalSort.Extension v1.0.2 via NuGet.

When do plan to release for .Net 7 resp. .Net 8? Thank you.

Can you please consider strong naming your assembly so that it may be used by projects that use a strong name?

There are many more Unicode codepoints that can be used as digits, as can be seen here: https://www.compart.com/en/unicode/category/Nd Each of these has a numeric value assigned, for example https://www.compart.com/en/unicode/U+0A68 (which has the value 2).

I suggest using char.IsDigit instead to handle this correctly.

see https://github.com/christophwille/poc-oh/blob/main/src/NaturalSortTests/Program.cs for a comparison with StrCmpLogicalW:

Input: A, A10, A11, Z, A੨, A੨੨
NaturalSort.Extensions: A, A੨, A੨੨, A10, A11, Z
StrCmpLogicalW: A, A੨, A10, A11, A੨੨, Z

The sort order of StrCmpLogicalW makes perfect sense if you replace ੨ with 2.

The natural sort extension is very slow (~17 sec) sorting this list: naturalSort.txt

Regular StringComparer.OrdinalIgnoreCase is somewhere at 9ms.

Here's a little test project:
NaturalSortExtensionsTest.zip

What's the reason for the bad performance? And how can it be fixed?

Sorting strings that start with a period does not work as expected.
where should i fix it?

Actual behavior

C:\scripts\NaturalSort.Extension\format.ps1
C:\scripts\NaturalSort.Extension\LICENSE
C:\scripts\NaturalSort.Extension\NaturalSort.Extension.sln
C:\scripts\NaturalSort.Extension\NaturalSort.Extension.sln.DotSettings
C:\scripts\NaturalSort.Extension\NaturalSort.Extension.snk
C:\scripts\NaturalSort.Extension\README.md
C:\scripts\NaturalSort.Extension\.appveyor.yml
C:\scripts\NaturalSort.Extension\.editorconfig
C:\scripts\NaturalSort.Extension\.gitattributes
C:\scripts\NaturalSort.Extension\.gitignore

Expected behavior

C:\scripts\NaturalSort.Extension\.appveyor.yml
C:\scripts\NaturalSort.Extension\.editorconfig
C:\scripts\NaturalSort.Extension\.gitattributes
C:\scripts\NaturalSort.Extension\.gitignore
C:\scripts\NaturalSort.Extension\format.ps1
C:\scripts\NaturalSort.Extension\LICENSE
C:\scripts\NaturalSort.Extension\NaturalSort.Extension.sln
C:\scripts\NaturalSort.Extension\NaturalSort.Extension.sln.DotSettings
C:\scripts\NaturalSort.Extension\NaturalSort.Extension.snk
C:\scripts\NaturalSort.Extension\README.md