nhsuk-react-components's People
Stargazers
Watchers
nhsuk-react-components's Issues
Using Labels to select Radio and Checkbox elements doesn't work when children are nested
const WorkingComponent = () => (
<Radios>
<Radios.Radio value="1">Option 1</Radios.Radio>
<Radios.Radio value="2">Option 2</Radios.Radio>
</Radios>
)
const FaultyComponent = () => (
<Radios>
<div className="container">
<div className="row">
<div className="col-md-6">
<Radios.Radio value="1">Option 1</Radios.Radio>
</div>
<div className="col-md-6">
<Radios.Radio value="2">Option 2</Radios.Radio>
</div>
</div>
</div>
</Radios>
)This is because the IDs of the root components aren't passed down the tree. This can be fixed by "leasing" a unique ID from the root Radios component, but it also needs to be predictable for test purposes.
Many components do not propagate 'id' attribute
In the below example, the id of this_is_my_button does not show in the DOM.
<Button
disabled={!this.state.valid}
type="submit"
id="this_is_my_button"
>
Click Me!
</Button>
The missing id behaviour has ben noticed in the following components, but this list is not exhaustive:
- Button
- Header.Link
- Footer.Link
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.