[Bug] Storage device without smart support causes crash about homeassistant-openmediavault HOT 11 CLOSED

Detected I/O inside the event loop is not related, thats just connectivity check inside config flow.
You are getting a crash during physical disk detection. Can you debug it?

from homeassistant-openmediavault.

2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.omv_api] OpenMediaVault 192.168.178.71 query response: {'response': [{'devicename': 'mmcblk0', 'canonicaldevicefile': '/dev/mmcblk0', 'devicefile': '/dev/disk/by-id/mmc-SD32G_0x88a0e8a5', 'devicelinks': ['/dev/disk/by-id/mmc-SD32G_0x88a0e8a5', '/dev/disk/by-path/platform-fe340000.emmc2'], 'model': '', 'size': '31104958464', 'description': 'n/a [/dev/mmcblk0, 28.96 GiB]', 'vendor': '', 'serialnumber': '', 'israid': False, 'isroot': False}, {'devicename': 'sda', 'canonicaldevicefile': '/dev/sda', 'devicefile': '/dev/disk/by-id/ata-WDC_WD30EFRX-68EUZN0_WD-WCC4N6TEKSHU', 'devicelinks': ['/dev/disk/by-id/ata-WDC_WD30EFRX-68EUZN0_WD-WCC4N6TEKSHU', '/dev/disk/by-id/wwn-0x50014ee2b6c6ebef', '/dev/disk/by-path/platform-fd500000.pcie-pci-0000:01:00.0-usb-0:1:1.0-scsi-0:0:0:0'], 'model': 'EFRX-68EUZN0', 'size': '3000592982016', 'description': 'EFRX-68EUZN0 [/dev/sda, 2.72 TiB]', 'vendor': 'WDC WD30', 'serialnumber': 'WD-WCC4N6TEKSHU', 'israid': False, 'isroot': False}, {'devicename': 'sdb', 'canonicaldevicefile': '/dev/sdb', 'devicefile': '/dev/disk/by-id/usb-KingDian_S400_120GB_000000123AE3-0:0', 'devicelinks': ['/dev/disk/by-id/usb-KingDian_S400_120GB_000000123AE3-0:0', '/dev/disk/by-path/platform-fd500000.pcie-pci-0000:01:00.0-usb-0:2:1.0-scsi-0:0:0:0'], 'model': 'S400 120GB', 'size': '120034123776', 'description': 'S400 120GB [/dev/sdb, 111.79 GiB]', 'vendor': 'KingDian', 'serialnumber': '000000123AE3', 'israid': False, 'isroot': True}], 'error': None}
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.helper] Processing source [{'devicename': 'mmcblk0', 'canonicaldevicefile': '/dev/mmcblk0', 'devicefile': '/dev/disk/by-id/mmc-SD32G_0x88a0e8a5', 'devicelinks': ['/dev/disk/by-id/mmc-SD32G_0x88a0e8a5', '/dev/disk/by-path/platform-fe340000.emmc2'], 'model': '', 'size': '31104958464', 'description': 'n/a [/dev/mmcblk0, 28.96 GiB]', 'vendor': '', 'serialnumber': '', 'israid': False, 'isroot': False}, {'devicename': 'sda', 'canonicaldevicefile': '/dev/sda', 'devicefile': '/dev/disk/by-id/ata-WDC_WD30EFRX-68EUZN0_WD-WCC4N6TEKSHU', 'devicelinks': ['/dev/disk/by-id/ata-WDC_WD30EFRX-68EUZN0_WD-WCC4N6TEKSHU', '/dev/disk/by-id/wwn-0x50014ee2b6c6ebef', '/dev/disk/by-path/platform-fd500000.pcie-pci-0000:01:00.0-usb-0:1:1.0-scsi-0:0:0:0'], 'model': 'EFRX-68EUZN0', 'size': '3000592982016', 'description': 'EFRX-68EUZN0 [/dev/sda, 2.72 TiB]', 'vendor': 'WDC WD30', 'serialnumber': 'WD-WCC4N6TEKSHU', 'israid': False, 'isroot': False}, {'devicename': 'sdb', 'canonicaldevicefile': '/dev/sdb', 'devicefile': '/dev/disk/by-id/usb-KingDian_S400_120GB_000000123AE3-0:0', 'devicelinks': ['/dev/disk/by-id/usb-KingDian_S400_120GB_000000123AE3-0:0', '/dev/disk/by-path/platform-fd500000.pcie-pci-0000:01:00.0-usb-0:2:1.0-scsi-0:0:0:0'], 'model': 'S400 120GB', 'size': '120034123776', 'description': 'S400 120GB [/dev/sdb, 111.79 GiB]', 'vendor': 'KingDian', 'serialnumber': '000000123AE3', 'israid': False, 'isroot': True}]
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.helper] Processing entry {'devicename': 'mmcblk0', 'canonicaldevicefile': '/dev/mmcblk0', 'devicefile': '/dev/disk/by-id/mmc-SD32G_0x88a0e8a5', 'devicelinks': ['/dev/disk/by-id/mmc-SD32G_0x88a0e8a5', '/dev/disk/by-path/platform-fe340000.emmc2'], 'model': '', 'size': '31104958464', 'description': 'n/a [/dev/mmcblk0, 28.96 GiB]', 'vendor': '', 'serialnumber': '', 'israid': False, 'isroot': False}
2020-05-11 14:53:02 INFO (SyncWorker_0) [homeassistant.loader] Loaded climate from homeassistant.components.climate
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.helper] Processing entry {'devicename': 'sda', 'canonicaldevicefile': '/dev/sda', 'devicefile': '/dev/disk/by-id/ata-WDC_WD30EFRX-68EUZN0_WD-WCC4N6TEKSHU', 'devicelinks': ['/dev/disk/by-id/ata-WDC_WD30EFRX-68EUZN0_WD-WCC4N6TEKSHU', '/dev/disk/by-id/wwn-0x50014ee2b6c6ebef', '/dev/disk/by-path/platform-fd500000.pcie-pci-0000:01:00.0-usb-0:1:1.0-scsi-0:0:0:0'], 'model': 'EFRX-68EUZN0', 'size': '3000592982016', 'description': 'EFRX-68EUZN0 [/dev/sda, 2.72 TiB]', 'vendor': 'WDC WD30', 'serialnumber': 'WD-WCC4N6TEKSHU', 'israid': False, 'isroot': False}
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.helper] Processing entry {'devicename': 'sdb', 'canonicaldevicefile': '/dev/sdb', 'devicefile': '/dev/disk/by-id/usb-KingDian_S400_120GB_000000123AE3-0:0', 'devicelinks': ['/dev/disk/by-id/usb-KingDian_S400_120GB_000000123AE3-0:0', '/dev/disk/by-path/platform-fd500000.pcie-pci-0000:01:00.0-usb-0:2:1.0-scsi-0:0:0:0'], 'model': 'S400 120GB', 'size': '120034123776', 'description': 'S400 120GB [/dev/sdb, 111.79 GiB]', 'vendor': 'KingDian', 'serialnumber': '000000123AE3', 'israid': False, 'isroot': True}
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.omv_api] OpenMediaVault 192.168.178.71 query: Smart, getInformation, {'devicefile': '/dev/mmcblk0'}, {'updatelastaccess': False}
2020-05-11 14:53:02 INFO (MainThread) [homeassistant.setup] Setting up zeroconf
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.omv_api] OpenMediaVault 192.168.178.71 query response: {'response': None, 'error': {'code': 0, 'message': "Device '/dev/mmcblk0' does not support S.M.A.R.T.", 'trace': "OMV\AssertException: Device '/dev/mmcblk0' does not support S.M.A.R.T. in /usr/share/php/openmediavault/system/storage/storagedevice.inc:214\nStack trace:\n#0 /usr/share/openmediavault/engined/rpc/smart.inc(423): OMV\System\Storage\StorageDevice->assertHasSmartSupport()\n#1 [internal function]: Engined\Rpc\Smart->getInformation(Array, Array)\n#2 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)\n#3 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod('getInformation', Array, Array)\n#4 /usr/sbin/omv-engined(537): OMV\Rpc\Rpc::call('Smart', 'getInformation', Array, Array, 1)\n#5 {main}"}}
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.helper] Processing source [None]
2020-05-11 14:53:02 DEBUG (SyncWorker_13) [custom_components.openmediavault.helper] Processing entry None

from homeassistant-openmediavault.

I see, there is an MMC card which is causing issues. I should have a reader and a card somewhere, so it should not be a problem to fix.

from homeassistant-openmediavault.

So, I was not able to able to reproduce on my server by connecting a card reader with a card.
I managed to get old pi2, so I should be able to replicate the issue now and solve it soon.

from homeassistant-openmediavault.

So, I was not able to able to reproduce on my server by connecting a card reader with a card.
I managed to get old pi2, so I should be able to replicate the issue now and solve it soon.

Cool let me know if you need any other info! :)

from homeassistant-openmediavault.

Installation took 2 hours on poor pi2, but I finally got this error reproduced. So all good.

from homeassistant-openmediavault.

That was a simple fix once I got it reproduced.
Fix released in v1.1.1

from homeassistant-openmediavault.

Looks like the last update fixed it:

Nice work!

from homeassistant-openmediavault.

perfect.
are those internal 1 and internal 2 correct names?

from homeassistant-openmediavault.

perfect.
are those internal 1 and internal 2 correct names?

Correct. Although I use a slightly more readable display name for the HA gauge card, here's the Labels list from OMV directly:

from homeassistant-openmediavault.

Thats perfectly fine then, I just wanted to make sure :)

from homeassistant-openmediavault.