tobiaslounsbury / civicrm-simple-workflow Goto Github PK

For example, if I add a profile named "Student Registration Form" to the workflow, the breadcrumb is named "Student Registration Form- none -- select -- select -."

It's a trivial bug. I can manually update the Breadcrumb field and upon save it displays as expected.

Sometime between 4.6.3 and 4.6.8 CiviCRM added a feature to Contribution forms where a total price recalculation triggers some javascript that makes the billing info block appear/disappear on the page. This is a problem for the Workflow because it puts the billing info block on every page where a selection is made.

The BAO and DAO classes need to be refactored to conform to Civi Standards. As well as to declare Workflows as an available entity.

The rendering of the progress bar needs to be refactored and modularized so that different ui's may be used/created and dropped in without needing to conform to the old format.
In this process progress completion should be stored in some sort of state object that can then be used to trigger any ui updates via hooks to whatever rending function is currently being employed. This would allow for a bound data rendering setup such as a small VueJS component, Angular implementation, or further expansion of non UL based layouts such as SVG.

Refactor the eventing system so that step handlers don't need to bind to an arbitrary DOM node or attempt to watch the action window at all. Workflow should handle delegating events that other steps will need so they don't have to do the hackish stuff that has been done with waiting for the creation of the action window.

When used in conjunction with the CiviDiscount module, when someone uses the Apply button to apply the discount and see the results, the workflow fails to reload.

When the Apply button isn't clicked, the discount still gets applied to the transaction, so for a quick workaround we will hide the Apply button.

Add support for managed entities to be created of complete workflows.

Add custom Permissions that allow site admins to delegate who can edit workflows, without requiring them to grant administer civicrm to anyone who is going to modify a button label.

Many of the functions in workflow_execute do not have any code comments/function documentation above them. This should be done for readability and self-documentation.

The way we are including built in steps is a bit hackish, and should be refactored to use our own step-type hook. This will allow us to refactor the code for standalone and injected pages.

The use of global and worse, semi-global variables should be fixed so that everything is encompassed under the CRM.Workflow namespace.

Samples and Documentation are needed before a general release. This issue it to keep track of the fact that some good user documentation is needed.

When an included ajax form is successfully submitted the system tries to call a snippet method resetUrl. The method causes the page to reload, thus we are calling snippet:destroy after submission. This causes the snippet not to exist and the call to resetUrl generates an error because the snippet doesn't exist.
The method of keeping the page from reloading needs to be refactored so it doesn't generate errors.