tj / better-assert Goto Github PK

The issues are closed there so I have to put my doubts here, although not so relevant:

It is unworthy to assert in browsers, considering the overheads in brand-width. It is also not meant for continuous development. I think console.assert is the right way to go.

I'm using babel as a part of ember-cli, had to use ember-browserify to be able to import better-assert, but now I get fs.readFileSync is not a function because this is a browser, of course.

This code:

import assert from 'npm:better-assert'

try {
    console.log('before calling assert')
    assert('true')
    console.log('called assert')
    assert(false)
    console.log('called with false')
} catch (e) {
    console.log('caught err'+e.stack)
}

Prints this:

before calling assert
cat.js:7 called assert
cat.js:11 caught errTypeError: fs.readFileSync is not a function
    at assert (http://localhost:4200/assets/vendor.js:65236:16)
    at Module.callback (http://localhost:4200/assets/dynamic-segments.js:385:35)
    at Module.exports (http://localhost:4200/assets/vendor.js:131:32)
    at requireModule (http://localhost:4200/assets/vendor.js:30:18)
    at Class._extractDefaultExport (http://localhost:4200/assets/vendor.js:144697:20)
    at Class.resolveOther (http://localhost:4200/assets/vendor.js:144432:32)
    at Class.superWrapper (http://localhost:4200/assets/vendor.js:35482:22)
    at Class.resolve (http://localhost:4200/assets/vendor.js:16205:43)
    at resolve (http://localhost:4200/assets/vendor.js:12565:36)
    at Object.resolve (http://localhost:4200/assets/vendor.js:12025:21)

Ember goliath generates horrible stack trace! 💯 :)

Going to fork and see what I can do..!

As the regex is configured at the moment, it is not possible to have line breaks in the code that is to be asserted. This could be fixed either by adding a separate method for doing asserts on code with line breaks (if todays behavior is needed), or adapting the regex to accept line breaks.

Is this something that could be fixed?

I like.

Would be cool if it included what it saw in the error message:

- AssertionError: 'number' == typeof user.age.
+ AssertionError: 'number' == typeof user.age. user.age is undefined.
    at test (/Users/tj/projects/better-assert/example.js:9:3)
    at Object.<anonymous> (/Users/tj/projects/better-assert/example.js:4:1)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.runMain (module.js:492:10)
    at process.startup.processNextTick.process._tickCallback (node.js:244:9)

would be nice to support the string diffs like should.js does. not sure what that involves to get it working with mocha

Basically if you name the assert function other than "assert" the regex fails.

const betterAss = require("./index");
betterAss(1 === 2);

~/better-assert/index.js:30
  var src = line.match(/assert\((.*)\)/)[1];
                                        ^

TypeError: Cannot read property '1' of null
    at assert (~/better-assert/index.js:30:41)
    at Object.<anonymous> (~/better-assert/fn-name-test.js:4:1)

TypeError: Cannot read property '1' of null

The callsite returns a line number for compiled code but it's trying to read the line from uncompiled one.

The current version is 8 commits behind. Furthermore, the newest version of the npm package does not yet include the license (see #11).