titusz / jcs Goto Github PK

One of the dangers is that python integers can be outside the range of floats which are used for JCS.

This causes:

>>> jcs.canonicalize(2**60)
b'1152921504606847000'
>>> 2**60
1152921504606846976

This should raise a ValueError or other exception when the output from canonicalize does not match the input. This can cause security issues w/ signatures as it allows modification of the object in undetectable and unexpected ways.

I'd be fine w/ only disabling the exception when an argument is provided, say, allow_integer_mismatch=True.