The ibooks from titusz

ibooks's People

Contributors

Stargazers

Watchers

ibooks's Issues

Throw "Not an iBooks file" Exception in constructor

Current version:

>>> f = ibooks.iBooks('E:\\tmp\\_cleanup\\some-nonsense-file.dat')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\Strayer\Envs\bla\lib\site-packages\ibooks.py", line 26, in __init__
    with zipfile.ZipFile(self.filepath, 'r') as zipreader:
  File "C:\python27\Lib\zipfile.py", line 766, in __init__
    self._RealGetContents()
  File "C:\python27\Lib\zipfile.py", line 807, in _RealGetContents
    raise BadZipfile, "File is not a zip file"
zipfile.BadZipfile: File is not a zip file

The constructor should not explode on this - it may also be reasonable to check even working zip files if they are an actual iBooks file:

>>> f = ibooks.iBooks('E:\\tmp\\_cleanup\\some-nonsense-file.zip')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\Strayer\Envs\bla\lib\site-packages\ibooks.py", line 27, in __init__
    with zipreader.open('OPS/ibooks.opf') as opf_file:
  File "C:\python27\Lib\zipfile.py", line 957, in open
    zinfo = self.getinfo(name)
  File "C:\python27\Lib\zipfile.py", line 905, in getinfo
    'There is no item named %r in the archive' % name)
KeyError: "There is no item named 'OPS/ibooks.opf' in the archive"

Recommend Projects