🚀 Feature request

Attributes sort order

Description

*attr
#attr
attr
[attr]
[(attr)]
(attr)

Example

<div
    *ngIf="predicate"
    #block
    class="classname"
    [model]="model"
    (click)="onClick()"
></div>

• Integrate @angular-eslint/builder with angular.json when it will be ready.
• Implement easy integration with this builder and @tinkoff/linters to target projects.
• Update README with installation guide.

Please provide support for verifying Angular's best practices. E.g. linting Angular component's ChangeDetectionStrategy. See http://codelyzer.com/rules/

Typescript v5 introduced the feature that allows to extend from multiple tsconfig files, e.g

{
  "extends": ["@tinkoff/typescript-config/tsconfig.base", "@tsconfig/node16/tsconfig.json"],
  "compilerOptions": {}
  ...
}

If a project uses such tsconfig.json, the eslint fails with error

Oops! Something went wrong! :(

ESLint: 8.45.0

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Array
Occurred while linting "..."
Rule: "import/no-cycle"
    at new NodeError (node:internal/errors:387:5)
    at validateString (node:internal/validators:162:11)
    at Object.join (node:path:1172:7)
   ...

There is an issue in eslint-plugin-import import-js/eslint-plugin-import#2751

I see 2 possible solutions:

1. Since the author is not interested in solving the problem, we can migrate to eslint-plugin-i, which is actually fork of eslint-plugin-import with some improvements.
2. Override the tsconfig-paths in package.json

  "overrides":{
    "tsconfig-paths": "^4.0.0"
  },

@typescript-eslint/member-ordering is disabled by default

And sort-class-members rules works for typescript code.

It is a problem, because eslint-plugin-sort-class-members didn't respect many typescript features.

Also, sort-class-members rules is very React class components specific.

Looks like we need to few changes:

1. Update and enable @typescript-eslint/member-ordering rules for TS code
2. Move React specific sort-class-members rules from @tinkoff/eslint-config to @tinkoff/eslint-config-react, only for js/jsx files

1.0.0

• Introducing eslint
• Warnings about changes by new code style
• Migration of tinkoff- rules natively to eslint

1.1.0

• Same errors (backwards compatible) and new warnings for angular and rxjs

2.0.0

• Completely removing tslint rules and configs
• Warnings from v1.* turns into errors in accordance with new code style, angular and rxjs
• Warnings about more strict rules in accordance to best-practices (sonarjs, optimize-regex, no-use-before-define, etc)

https://www.npmjs.com/package/@tinkoff/eslint-config

you should remove eslint, prettier, and @tinkoff/eslint-config internal dependencies from your project package.json. - сам конфиг-то удалять не нужно.

About

Hacktoberfest is DigitalOcean's annual event that encourages people to contribute to Open Source projects. In short, each participant must make four contributions to OSS in order to receive one of two prizes: a personalized planted tree or a Hacktoberfest T-shirt.

Junior Level

• Fix issue in documentation #201
• Fix bug TypeError: Cannot read property 'type' of undefined #115

Middle Level

• Add unicorn plugin as sub-plugin to @tinkoff/eslint-config-angular
• Add unit test with combination ['@tinkoff/eslint-config/app', '@tinkoff/eslint-config-angular']
• Migrate to npm 7 for drop node.js 12 #121
• Add stylelint-scss package with some rules to @tinkoff/stylelint-config https://www.npmjs.com/package/stylelint-scss
• Warnings about more strict rules in accordance to best-practices (sonarjs, optimize-regex, no-use-before-define, etc) in @tinkoff/eslint-config

High Level

• Migrate from ESLint 7 to ESLint 8
• Add @angular-eslint plugin to @tinkoff/eslint-config-angular #163
• Completely removing tslint rules and configs
• Support all typescript rules in @tinkoff/eslint-config-angular:

Motivation

Most of the time we just ignore "warn" rules.
If the rule is really important, it is better to prefer "error", otherwise we can just skip this rule.

Solution

Changing all "warn" to "error" - it is a breaking change, so I propose that we can turn off most of warnings, and create another package with more strict rules.

Description

Prettier fails on package.json with Unexpected token '.' error. It happens due to prettier-plugin-sort-package.js syntax (line 20, line 28) since old node versions can't work with these. Can you specify engines in package.json?

Reproduction

prettier package.json

Environment

node 12
1.32.1

can you learn how to quickly change stylelint to work with scss?

Problem

Nx generate workspaces with eslint and prettier in dependencies.

@tinkoff/eslint-config has eslint and prettier in dependencies too, and recommends users to prevent install this packages.

So, it's easy to have missmatched versions or duplicates of this packages.

Solution

Looks like the best solution is move eslint, prettier and other core dependencies of @tinkoff/eslint-config to peerDependencies

Then we need to write a complete migration guider.

And add npm >= 7 at engines field

Update lock file

Move to workspaces from lerna

Reproduce

install dependencies:

npm i @tinkoff/eslint-config @tinkoff/eslint-config-react @tinkoff/eslint-plugin-tramvai

modyfy .eslintrc:

module.exports = {
    extends: [
        '@tinkoff/eslint-config/app',
        '@tinkoff/eslint-config/jest',
        '@tinkoff/eslint-config-react',
        'plugin:@tinkoff/tramvai/recommended',
    ],
    rules: {
        '@typescript-eslint/naming-convention': 1,
    },
};

add destructurisation in js file:

const x = ({ ...y }) => {}

Error

TypeError: Cannot read property 'type' of undefined
Occurred while linting /Users/b.ponomarenko/Desktop/es-app/index.js:1
    at getIdentifiersFromPattern (/Users/b.ponomarenko/Desktop/es-app/node_modules/@typescript-eslint/eslint-plugin/dist/rules/naming-convention.js:532:21)
    at /Users/b.ponomarenko/Desktop/es-app/node_modules/@typescript-eslint/eslint-plugin/dist/rules/naming-convention.js:553:21
    at Array.forEach (<anonymous>)
    at getIdentifiersFromPattern (/Users/b.ponomarenko/Desktop/es-app/node_modules/@typescript-eslint/eslint-plugin/dist/rules/naming-convention.js:544:32)
    at /Users/b.ponomarenko/Desktop/es-app/node_modules/@typescript-eslint/eslint-plugin/dist/rules/naming-convention.js:397:21
    at Array.forEach (<anonymous>)
    at FunctionDeclaration, TSDeclareFunction, FunctionExpression, ArrowFunctionExpression (/Users/b.ponomarenko/Desktop/es-app/node_modules/@typescript-eslint/eslint-plugin/dist/rules/naming-convention.js:392:29)
    at /Users/b.ponomarenko/Desktop/es-app/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/b.ponomarenko/Desktop/es-app/node_modules/eslint/lib/linter/safe-emitter.js:45:38)

Problem

Error only with enabled @typescript-eslint/naming-convention rule

Not all projects use a prettier. Is it possible to connect rules from a prettier by condition?

https://github.com/TinkoffCreditSystems/linters/blob/dd87c96e2a0af9e288160aef15b69daff774a80e/packages/eslint-config/index.js#L9

This extend removes some of the rules that a prettier can be responsible for. But if the project does not use a prettier, some of the rules are simply lost.

I propose to add a condition if a prettier is used in the project. I think it can be determined using this package.

If that's acceptable, I can make PR.

reference: https://www.npmjs.com/package/eslint-plugin-no-cyrillic-string

Stylelint throw error
Unexpected unknown function "fade" function-no-unknown
fade - is valid less function
function-no-unknown for less config must be configured with second parameter ignoreFunctions with list of less functions for prevent this error

Into stylelint config contains rule custom-property-pattern, that dictate use only kebab case:

'custom-property-pattern': [
			'^([a-z][a-z0-9]*)(-[a-z0-9]+)*$',
			{
				message: 'Expected custom property name to be kebab-case',
			},
		],

But taiga ui contains vars like --tui-text_body-m, obviously not match that pattern,

may custom-property-pattern needs to reconfigure for allowing all taiga vars?

• Migrate from CLIEngine to ESlint constructor in tests

Привет! Из-за экспортнутого html.js из '@tinkoff/eslint-config-angular' не получается использовать никакие правила для html, а в частности extends: ['plugin:@angular-eslint/template/recommended']. Возможно этот импорт как-то омитнуть? Возможно все ломается из-за того extends для .ts получает .html.

Для воспроизведения достаточно в overrides для files: ['*.ts'] в extends добавить '@tinkoff/eslint-config-angular'. тогда никакие правила для files: ['*.html'] не применяются

When using v1.51.0 of @tinkoff/eslint-config-angular following errors are occurs

with eslint 7.x - requires a peer of eslint@^8.0.0 but none is installed
with eslint 8.x - requires a peer of eslint@^5.0.0 || ^6.0.0 || ^7.0.0 but none is installed.