Code Monkey home page Code Monkey logo

foreman_concrete's People

Contributors

ekohl avatar timogoebel avatar

Stargazers

 avatar

Watchers

 avatar  avatar

Forkers

ekohl

foreman_concrete's Issues

Concrete fails to render a template if a non-API call wants rendered JSON

Currently, if a non-API controller chooses to render a method (an ajax method for instance) as json, any exception thrown in there will just lead to an ActionView::MissingTemplate error in Sentry instead of the actual exception thrown.

Creating a foreman_concrete/500.json.rabl template - or erb etc - should solve this issue.

Or perhaps it'd be possible to overwrite the rendering of the 500 template, to always enforce HTML rendering, regardless of the requested output.

Update to be compatible with current sentry-raven

The dependency on sentry-raven is here:

s.add_runtime_dependency 'sentry-raven', '~> 2.7'

Versions 2.x require faraday < 1 but we're updating to 1.x (while 2.x is also out). This limits us in packaging.

It looks like you can easily update to sentry-raven 3.x, which itself is also in maintenance mode. Another option is to move to the current version which has a new main class (Sentry).

If you're no longer interested in the plugin we can also drop it from packaging.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.