timdubbins / tap Goto Github PK

I forgot to mention this...

Your latest AUR package doesn't pass the source file integrity checks. Had to bypass the checks with:

yay -S --mflags --skipinteg tap

This was a surprise. Shouldn't this play the default directory, noninteractively?

i love this project, ive been looking for a rust music player for ages, but when i compile and run it, the background color is this salmon-like color, not the black like in the screenshot, all the other colors of the text are the same, i dont know if its because i compiled it wrong, i just used cargo build

OS: Arch Linux
Version: compile from git

Compile argument : cargo build --release

backtrace:

./tap
thread 'main' panicked at 'cannot sample empty range', /home/chromer/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rand-0.8.5/src/rng.rs:134:9
stack backtrace:
   0:     0x7f40d5682f61 - <unknown>
   1:     0x7f40d56a7b1f - <unknown>
   2:     0x7f40d5680179 - <unknown>
   3:     0x7f40d5682d75 - <unknown>
   4:     0x7f40d56842a3 - <unknown>
   5:     0x7f40d5684034 - <unknown>
   6:     0x7f40d5684829 - <unknown>
   7:     0x7f40d56846e1 - <unknown>
   8:     0x7f40d56833c6 - <unknown>
   9:     0x7f40d5684472 - <unknown>
  10:     0x7f40d5444f73 - <unknown>
  11:     0x7f40d5445003 - <unknown>
  12:     0x7f40d5487090 - <unknown>
  13:     0x7f40d54e8970 - <unknown>
  14:     0x7f40d54c6d8b - <unknown>
  15:     0x7f40d54fe3c9 - <unknown>
  16:     0x7f40d545f0ed - <unknown>
  17:     0x7f40d54d29a3 - <unknown>
  18:     0x7f40d5493569 - <unknown>
  19:     0x7f40d567a65b - <unknown>
  20:     0x7f40d545f1e5 - <unknown>
  21:     0x7f40d5027cd0 - <unknown>
  22:     0x7f40d5027d8a - __libc_start_main
  23:     0x7f40d5445615 - <unknown>
  24:                0x0 - <unknown>

UPDATE: Same panic with 0.4.6 release.
(https://github.com/timdubbins/tap/releases/download/v0.4.6/tap_0.4.6-x86_64-unknown-linux-gnu.tar.gz)

If you have a sub-directory that doesn't have any audio files or is empty, tap refuses to play the album even though the directory has audio files. Obviously that sub-directory could be removed, but some people may have non-audio files in sub-directories e.g. cover images.

Ideally, tap could just silently ignore sub-directories without audio files and still play the audio files found in the directory?

BTW, volume control is implemented beautifully without affecting the cleanness of the interface. Maybe it would be good to save the volume level so output is at the same level when restarting tap?

The black background feels quite jarring when everything else appears light (seeing white writing on a black background doesn't work well in Sunlight).

Could there be some option to remove the background colours and simply use the terminal's default colours?

Opus files are not recognized as audio files.

I've run RUST_BACKTRACE=1 cargo install --path . to install, but get the following error:

  /home/ghost/Projects/tap/target/release/build/ncurses-655630ba6bec2a2c/out/chtype_size.c:6:10: fatal error: ncurses.h: No such file or directory
      6 | #include <ncurses.h>
        |          ^~~~~~~~~~~
  compilation terminated.
  thread 'main' panicked at 'assertion failed: command.status().expect(\"compilation failed\").success()', /home/ghost/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ncurses-5.101.0/build.rs:105:5
  stack backtrace:
     0: rust_begin_unwind
     1: core::panicking::panic_fmt
     2: core::panicking::panic
     3: build_script_build::check_chtype_size
     4: build_script_build::main
     5: core::ops::function::FnOnce::call_once
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
warning: build failed, waiting for other jobs to finish...
error: failed to compile `tap v0.4.7 (/home/ghost/Projects/tap)`, intermediate artifacts can be found at `/home/ghost/Projects/tap/target`.

I've installed the ncurses package (ncurses-6.4_2), but this didn't help.

• OS: Void Linux

NB: I have no idea how rust works, I'm just following the error message, so feel free to close the issue if I'm just missing something simple.

I'm mighty impressed with tap.

I note it seeks inspiration from cmus. That offers gapless playback. Is there any chance of adding gapless playback for tap please?

About 10% of my music collection is ruined without it.