Code Monkey home page Code Monkey logo

Comments (11)

skyzh avatar skyzh commented on August 18, 2024 3

Looks good! I'd +1 for this.

from community.

tisonkun avatar tisonkun commented on August 18, 2024 2

FYI - repo setup at https://github.com/tikv/match-template/ and I publish the crate at https://crates.io/crates/match-template, as well as add @tikv/tikv-maintainers as its owner. @BusyJay @andylokandy you may update the tikv part and I'm glad to know if Databend or other project use this crate also.

from community.

BusyJay avatar BusyJay commented on August 18, 2024 1

I think a standalone repository is better since it hardly changes. Messing with a large code repository doesn't feel good to me.

from community.

tisonkun avatar tisonkun commented on August 18, 2024 1

@andylokandy you may already have the privilege to create the repo and set up. I'm unsure whether the vote progress still works and if you don't mind, you can create a pull request to formally meet a consensus.

from community.

BusyJay avatar BusyJay commented on August 18, 2024 1

Cool! Just a hint, if using git filter-branch to extract the subdirectory/component, we can retain all the related history.

from community.

BusyJay avatar BusyJay commented on August 18, 2024

+1

from community.

tisonkun avatar tisonkun commented on August 18, 2024

+1

One things to point out is that we can publish that crate even under this repository with setting publish=true and prepare a publishing workflow. Cross repositories development could be a painful experience especially when code is tightly coupled.

from community.

andylokandy avatar andylokandy commented on August 18, 2024

TiKV can import match_template from crates.io, so I think it won't be a problem.

from community.

andylokandy avatar andylokandy commented on August 18, 2024

Unfortunately, I don't have that privilege. @sunxiaoguang could you take a look?

from community.

tisonkun avatar tisonkun commented on August 18, 2024

@andylokandy you may create a pull request to formally document a consensus and I'm glad to do you a favor with that consensus.

from community.

tisonkun avatar tisonkun commented on August 18, 2024

@BusyJay I forgot this topic XD

from community.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.