Code Monkey home page Code Monkey logo

Comments (8)

tisonkun avatar tisonkun commented on July 19, 2024 1

the model retains.

More details: Some of our repositories that do not have particularly many collaborators do not really need to use bots (it will bring the cost of learning and use). So if we use the GitHub teams permissions model, we can work with bots on larger repositories and use GitHub permissions directly on smaller repositories.

Yes. And then rust-prometheus works well as is. But still I'd like to reach out them for a consistent view.

from community.

tisonkun avatar tisonkun commented on July 19, 2024

cc @hi-rustin @Mini256 @BusyJay

from community.

hi-rustin avatar hi-rustin commented on July 19, 2024

I propose that we refine the permissions to:

  1. triage -> can approve (reviewers)
  2. write above -> can apporve and merge (committers and maintainers)

This way we can have more permissions control. Now we have people above write permission as both reviewers and committers, so it is not possible to distinguish reviewer and committer permissions very well.

What do you think?

from community.

hi-rustin avatar hi-rustin commented on July 19, 2024

(bot has a limit on events received),

Some details: the limitation in this place is the API rate limit; the bot can accept all events, but can't respond on so many repositories because GitHub has strict limitations on API usage.

from community.

hi-rustin avatar hi-rustin commented on July 19, 2024

the model retains.

More details: Some of our repositories that do not have particularly many collaborators do not really need to use bots (it will bring the cost of learning and use). So if we use the GitHub teams permissions model, we can work with bots on larger repositories and use GitHub permissions directly on smaller repositories.

from community.

tisonkun avatar tisonkun commented on July 19, 2024

I propose that we refine the permissions to:

  1. triage -> can approve (reviewers)
  2. write above -> can apporve and merge (committers and maintainers)

This way we can have more permissions control. Now we have people above write permission as both reviewers and committers, so it is not possible to distinguish reviewer and committer permissions very well.

What do you think?

That makes sense to me.

from community.

tisonkun avatar tisonkun commented on July 19, 2024

Thanks to @hi-rustin 's excellent work ti-community-infra/tichi#597 and with the consensus reached at #122 we are going to apply the change of community governance in days.

from community.

tisonkun avatar tisonkun commented on July 19, 2024

Closed as implemented. You can still comment if there is any bad case found.

from community.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.