tiktok / rush-plugins Goto Github PK

Summary

Running the rush update on MacOS causes the command-line.json file in autoinstallers directory to change the line format to Windows lines (CRLF).

Repro steps

1. Be on MacOS (or presumably *nix would have the same issue)
2. Run rush update
3. Look at the generated files. They all use windows newlines:

• */autoinstallers/*/rush-plugins/rush-init-project-plugin/rush-init-project-plugin/command-line.json

Expected result: These files should use Unix (LF) style newlines (i.e. \n)

Actual result: These files use Windows (CRLF) style newlines (i.e. \r\n)

Details

Hi there we encounter an error while running rush init-project command:

After installing typescript globally pnpm install -g typescript it is fixed, any idea about what cause this problem?

If you use the documented setup for init.config.ts, the plugins internal ts-node build fails with the following error:

Starting "rush init-project"

? Please select a template node-lib
Hello from template configuration! "node-lib" /Users/michaelsitter/dev/web-projects/common/_templates/node-lib
⨯ Unable to compile TypeScript:
error TS5109: Option 'moduleResolution' must be set to 'Node16' (or left unspecified) when option 'module' is set to 'Node16'.

I think I managed to track the failure down to this line in TemplateConfiguration. I experimentally added module: 'none' & it resolves this issue, but it's not clear to me what should actually be happening here. Is ts-node supposed to be discovering a tsconfig file at this step, or is this intentionally hardcoded in the plugin?

I have a branch which reproduces this issue here: https://github.com/MichaelSitter/web-projects/tree/rush-init-project-ts-config-repro