Code Monkey home page Code Monkey logo

addons-server's Introduction

Code of conduct https://travis-ci.org/mozilla/addons-server.svg?branch=master Updates Python 3

Addons-Server

Welcome to the Addons Server repository! Please feel free to visit the web page of the current project hosted on addons.mozilla.org. If you want to install it follow our guide located in install docs. We'd love your help! You can come talk to us on irc.mozilla.org #amo if you have any questions.

Please report bugs here: https://github.com/mozilla/addons/issues or https://github.com/mozilla/addons-server/issues You can access the AMO dev environment at https://addons-dev.allizom.org/ and the AMO stage environment at https://addons.allizom.org/

You can join our mailing list at https://mail.mozilla.org/listinfo/dev-addons

Security Bug Reports

This code and its associated production web page are included in the Mozillaā€™s web and services bug bounty program. If you find a security vulnerability, please submit it via the process outlined in the program and FAQ pages. Further technical details about this application are available from the Bug Bounty Onramp page.

Please submit all security-related bugs through Bugzilla using the web security bug form. Never submit security-related bugs through a Github Issue or by email.

addons-server's People

Contributors

ag12r avatar andy-moz avatar clouserw avatar cvan avatar davedash avatar davidbgk avatar diox avatar entequak avatar eviljeff avatar gkoberger avatar jbalogh avatar karm46 avatar kumar303 avatar magopian avatar manxmensch avatar mattbasta avatar milupo avatar mohammedbelkacem avatar mstriemer avatar muffinresearch avatar ngokevin avatar oremj avatar petercpg avatar potch avatar pyup-bot avatar robhudson avatar spasovski avatar tofumatt avatar upwinxp avatar wagnerand avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

addons-server's Issues

Cannot login to my Firefox account. Internal Server Error

Problem:
When I try to login server responds with JSON: {detail : "Internal Server Error"}

Details:
I am developer of an addon for Thunderbird. On Friday I have added secondary email and made it primary. After that I have logged out. Now I cannot login.

This is copy of issue mozilla/addons#836. Guys there told me that Thunderbird addon accounts are separate from Fireforx'. Whom should I email for help?

Thunderbird Add Theme links broken

Describe the problem and steps to reproduce it:

All of the "Add Theme" links on the Thunderbird website (https://addons.thunderbird.net/en-US/thunderbird/themes/) are broken. Every time I click on the "Add Theme", the website redirects to the "We're sorry, but we can't find what you're looking for" page.

What happened?

Went to download a new theme for Thunderbird, cannot find a single "Add Theme" link that works.

What did you expect to happen?

The theme to download, especially for the recently added themes.

Anything else we should know?

Cannot upload WebExtension with WebExperiment

WebExtensions are the new kind of extensions, the only one that Firefox supports.
They are very new for Thunderbird. Thunderbird supports almost no APIs for WebExtensions yet.
Thus, any Thunderbird WebExtension likely has to create new APIs, via the WebExperiments API mechanism. It's essentially chrome code implementing new APIs. Security-wise, that's on the same level as bootstrapped addons.

We developed a WebExtension with 2 WebExperiment APIs. But addons.thunderbird.net refuses the upload.

Describe the problem and steps to reproduce it:

  1. Create a new extension
  2. Upload XPI of WebExtension with WebExperiment. Example XPI

What happened?

Upload refused
"
Error with latest.xpi
100% complete Ā· 49.91 KB of 49.91 KB
We have enabled a new linter to process your Add-on. Please make sure to report any issues on GitHub
Your add-on failed validation with 1 error.
You cannot submit this type of add-on
See full validation report
"
The full validation report finds 17 warnings about unknown APIs (the ones we created), but no errors.
"
General Tests
0 errors, 17 warnings, 0 notices
Security Tests
0 errors, 0 warnings, 0 notices
Extension Tests
0 errors, 0 warnings, 0 notices
Localization Tests
0 errors, 0 warnings, 0 notices
Compatibility Tests
0 errors, 0 warnings, 0 notices
"

What did you expect to happen?

Upload is allowed. Addon reviewers review it in the same way and with the same care as they review bootstrapped addons.

Anything else we should know?

Code for AMO addon linter that produces the error

Statistics dashboard for Thunderbird add-ons is not working since split from AMO

Describe the problem and steps to reproduce it:

Visit statistic dashboard of any Thunderbird add-on, e.g. https://addons.thunderbird.net/en-us/thunderbird/addon/customizemybird/statistics/?last=30
Page is not displayed correctly.

What happened?

Infinite loading screens, stats not updated for month.

What did you expect to happen?

Visual appearance of statistics like present before Thunderbird add-ons moved from https://addons.mozilla.org/ to https://addons.thunderbird.net/

Anything else we should know?

This issue is present for month. Strange nobody has reported anything yet.
1

Themes Won't Download

I am unable to download ANY themes. When I click on download, they all send me to the page that tells me the page doesn't exist.

I am able to download other types of add-ons.

How can I download themes?

Search appears to include Firefox add-ons.

Goto the search box and type thesauru

The drop down populated with many good looking matches.
Pressing return gives two dictionaries.
amothunderbirdnet

Clicking at least the first entry in the list drops me to AMO and a Firefox , not ATN and a Thunderbird or at worst a sea monkey add-on.

Cannot change default language

For some reason, the default language for my addon was set to German. I didn't intentionally set this.

Now, I cannot change it anymore.

Reproduction:

  1. Go to the addon settings page, to section "Add-on-Details" with a field "Default language"
  2. Click "Edit" above that section
  3. Change dropdown field "Default language" to "English (US)"
  4. Fill out the "Description" and "Homepage" fields. Note that they still say "German"/"Deutsch", which is wrong.
  5. Save

Actual result:

  • Error (in German): "Before changing your default language, you must have a name, summary, and description in that language. 'description' is still missing."
  • The changes are not saved
  • "Description" and "Homepage" fields still say "German", even though the "Default language" has been changed to "English".
  • I have no way to fix this.

Expected result:

  • Once I change the default language, the other 2 fields also change to that language.
  • Saving works
  • When navigating to my addon page as an end user with a language that the addon has no description translation for, the description is displayed in English, the new default language.

Can't upload an update for a theme

Describe the problem and steps to reproduce it:

Currently I can't upload an update for a theme, Phoenity Shredder.

What happened?

After uploading the page gets stuck at "Validating phoenity_shredder-3.5.47-tb.jar"

What did you expect to happen?

The validation process should finish.

Anything else we should know?

https://addons.thunderbird.net/en-US/developers/addon/phoenity-shredder/versions/submit/
Using 64-bit Firefox 61.01 on Linux, no interfering extensions AFAICS, this used to work on AMO.

ATN with WebExtension talks about Firefox all the time

ATN hasn't understood yet that it's about Thunderbird, not Firefox. :-)

Reproduction:

  • Upload a WebExtension, e.g. Owl

Actual results:

  1. By default, every version is compatible with Firefox only, an not compatible with Thunderbird. It should be inverse.

  2. While parsing the manifest, ATN should assume it's for Thunderbird, and not for Firefox. ( WebExtension manifests do not list applications.)

  3. I fixed the compatibility in the addon version settings page, added Thunderbird and not Firefox:
    image
    Yet, if the user goes to the "All versions" page, it still says in fine print (below the version number) that this is compatible with Firefox:
    image

  4. My addon page says very prominently, right to the addon name, in green: "compatible with Firefox 57+". Obviously, that's wrong. (Even though my addon is configured not to be compatible with Firefox, see above, so I cannot fix this even in the addon version settings.) This should be removed without replacement. This is the most obvious bug here, and probably also the easiest to fix.
    image

  5. Versions 60.3 is not known. See #49. Thus, manifest directive:

"applications": {
    "gecko": {
      "id": "[email protected]",
      "strict_min_version": "60.3"

fails directly during upload, because version 60.3 is not known in the list of versions. I was forced to remove the min version from the manifest.

  1. I cannot select Thunderbird categories, only Firefox categories. See #51.

Discovery Pane "learn more" link doesn't work.

This opens a video on the SeaMonkey page, but it doesn't do anything on the Thunderbird version. The video is pretty useless though, so this should probably either be removed or link to something on the Support site.

See also: Bug 1481089.

Clicking "Download for Linux" in Firefox attempts to install add-on in the browser

Describe the problem and steps to reproduce it:

(Please include as many details as possible.)

I went to https://addons.thunderbird.net/en-US/thunderbird/addon/lightning/ and clicked "Download for Linux". This is using Firefox 62 (beta) on Linux (Debian).

What happened?

Firefox asks whether I want to install the add-on.

What did you expect to happen?

Firefox should offer to download the add-on (I vaguely remember that to be the case on the old addons.mozilla.org page).

TB Add-ons Split from AMO Broke AMO Features within Thunderbird

Back when Thunderbird had their add-ons site split onto a new site, this had a side-effect of breaking all AMO features within Thunderbird (I'm using TB 60 beta 10). No add-ons can be updated automatically, add-ons canā€™t be searched within Thunderbird (but can be in Firefox/an internet browser as a workaround), nor light themes can be installed in Thunderbird from what I can gather with testing.

Extensions can be manually downloaded from Firefox/an internet browser, but can be manually installed in Thunderbird. Extensions have a work-around. Light themes have no work-around since you can't download them in Firefox/another internet browser to install in Thunderbird.

Anyways it was suggested for me to open a bug here from this page:
https://blog.mozilla.org/addons/2018/07/17/the-new-thunderbird-add-ons-site-is-now-live/

Not a proper error message displayed - sites are down for data copy

STR:

  1. Load AMO dev and switch to the old pages.
  2. From Other Applications drop down menu Click on Thunderbird and then on Seamonkey.

Expected results:
A proper message displayed when sites are down for data copy.

Actual results:
503 Service Temporarily Unavailable

Notes:
This issue is reproducible on AMO dev and AMO stage with FF61(Win10).
service unavailable

Dark theme download page does not exists

Describe the problem and steps to reproduce it:

(Please include as many details as possible.)

Dark theme download page does not exists.

What happened?

Download not works from the "add to thunderbird" button in "https://addons.thunderbird.net/en-US/thunderbird/addon/macos-sierra-dark/" responding "We're sorry, but we can't find what you're looking for."

What did you expect to happen?

Theme download

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)

Can't add new themes to Thunderbird

Hi,
Whenever I click on a link to add a theme to my thunderbird it comes up with this message:

"We're sorry, but we can't find what you're looking for.
The page or file you requested wasn't found on our site. It's possible that you clicked a link that's out of date, or typed in the address incorrectly.

If you typed in the address, please double check the spelling.
If you followed a link from somewhere, please file an issue. Tell us where you came from and what you were looking for, and we'll do our best to fix it.
Or you can just jump over to some of the popular pages on our website.

Are you interested in a list of featured add-ons?
Do you want to search for add-ons? You may go to the search page or just use the search field above.
If you prefer to start over, just go to the add-ons front page."

It is happening with every theme I try to install.

Parse Cloudfront logs for add-on user stats

In front of versioncheck.addons.thunderbird.net, Cloudfront sits. This means that most http requests won't reach the actual server, so we need to parse these logs to figure out user pings for add-on stats.

allow to display/search addons for specific version

current display shows addons for all versions.
An extended search would be nice to specify a version no or version range.

So I would get all TB 60 addons in a compact way. Currently, they are spread between hundreds of old addons and difficult to find.

Searching for addon inside TB can do that, but still the old addons are displayed greyed, so they take space in the list, and tere are pages only showing greyed (obsolete) addons

Changing application from Thunderbird to Firefox doesn't route back to addons.mozilla.org

STR:

  1. Load AMO -dev homepage
  2. From Other Applications switch to Thunderbird or Seamonkey
  3. Observe the URL
  4. Change back to Firefox
  5. Observe the URL again

Actual result:
After changing back to Firefox, the user lands on https://addons.thunderbird.net/en-US/firefox/

Expected result:
After changing back to Firefox, the user lands on https://addons-dev.allizom.org/en-US/firefox/

Notes:

  • reproduced on AMO -dev with FF60, Win10x64
  • this is linked to mozilla/addons#5537 which referenced to the new route created for Thunderbird and Seamonkey submissions

application route

Addon Validation Error (langpack)

Please attach a copy of your add-on, and fill in the following information:

  • Whether this error occurred during the submission of a new add-on, a new version of an existing add-on, a new file in an existing version, or an upload to the standalone validator.
    Ocurred uploading a new version of the addon, the upload form gives a validation error:
    Sorry, we couldn't load your WebExtension.
    Error: Validation was unable to complete successfully due to an unexpected error.

Check https://developer.mozilla.org/en-US/Add-ons/WebExtensions to ensure your webextension is valid or file a bug at http://bit.ly/1POrYYU

If I validate the addon in https://addons.mozilla.org it validates correctly and I can install the addon correctly in a thunderbird 60 clean install

thunderbird-60.0.1.ca-valencia.langpack.xpi.20180823-1821.zip

Reset ATN leader board

I think it makes sense to reset the leader board for reviewers starting the date we did the migration. I think this is just a matter of dropping rows from reviewer_scores dated before the migration.

@ryanleesipes to confirm we are doing this

Cloudflare breaks addon store functionality in torified Thunderbird - Please whitelist Tor in CF for addons.thunderbird.net

Describe the problem and steps to reproduce it:

While proxying Thunderbird through the Tor network, accessing any addons.thunderbird.net services in Thunderbird hits a CloudFlare CAPTCHA that cannot be solved. This prevents the updating of existing addons, browing of new addons, etc.

What did you expect to happen?

User should be able to keep addons up-to-date, download + install new addons, etc from Thunderbird addon store even if they are connecting via a known Tor exit node. They should not have to fill in a CAPTCHA, as it only appears during Addon store browsing and not when one is asking Thunderbird to update existing addons, leading to update failure without a clear user understanding of why it failed.

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)

Pages/services that need to whitelist Tor include:
services.addons.thunderbird.net
addons.thunderbird.net

This is how you whitelist Tor exits in CloudFlare:
https://support.cloudflare.com/hc/en-us/articles/203306930-Does-CloudFlare-block-Tor-

running foxes

Describe the problem and steps to reproduce it:

(Please include as many details as possible.)

What happened?

What did you expect to happen?

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)

Need 60.x versions for compat

On the addon version page, I can set the compatibility. But I cannot select Thunderbird version 60.3. Only 60.0, 60.0a1 and 60.0a2 are available. 60.1, 60.2, 60.3, 60.4 etc. are missing.

I need this, because my addon only works with 60.3 or later.

Unable to download (any?) theme

Describe the problem and steps to reproduce it:

(Please include as many details as possible.)
I went to the add-ons site via 1) the web site and 2) the extensions tab in thunderbird. I was looking for a dark theme (to match the new MacOS dark theme :).

But I tried multiple (also non-dark) themes, and all brought me to a 404 not found page when i clicked on the '+ add to Thunderbird' button.

What happened?

I got a 'We're sorry, but we can't find what you're looking for' page, instead of the plugin/theme being downloaded.

What did you expect to happen?

That the plugin/theme would be loaded.

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)
Not sure what other details could be of help, other than:
OS: MacOS High Sierra
Thunderbird Version: 52.9.1 (64-bit)
Browser: Chrome 69

Addon Validation Error

Dear Mozilla Team,

  • This is a Thunderbird add-on related validation error.
  • This error occurred during the provisioning of an update for an existing add-on:
    • We allow and encourage an upgrade but you cannot reverse this process. Once your users have the WebExtension installed, they will not be able to install a legacy add-on.
    • Since this is a TB 60 hybird add-on I think the strict validation is too strict in this case.
  • My add-on is currently listed (1.0.0.0)
  • Submission URL: https://addons.thunderbird.net/de/developers/addon/create-jira-issue/versions/submit/
  • Submission time approx.: 2018-08-15 13:53:00 UTC+2/CEST/Central European Summer Time/Germany
  • I had to include the manifest.json file with the flag "legacy": true in order for Thunderbird 60 to load my (still) legacy add-on. This was suggested here: Thunderbird/Add-ons Guide 62
  • The only "real" change apart from i18n cleanup is the handling of the File's Promise returned by the API call that was introduced.
  • The add-on was fully functional on my machines.
  • I would like to postpone a WebExtension rewrite of this add-on until the API has stabilized.
  • I have received numerous requests from users that were already using TB 60.x pre-relases thus I would like to have a release in the offical channel. please.

Please see the attached file (zip containing xpi) here:
createjiraissue-1.0.0.60.zip

I also ran the addons-linter on my add-on and fixed all the errors/warnings raised:

09:07 $ addons-linter createjiraissue.xpi
Validation Summary:

errors 0
notices 0
warnings 0

But uploading to https://addons.thunderbird.net/de/developers/addon/create-jira-issue/versions/submit/ still fails with the same error message.

Thanks in advance,
cheers, Holger

Add-on validation error

Describe the problem and steps to reproduce it:

When submitting an updated version of an add-on via the Thunderbird add-on system I get told there's been an unexpected error. The error message is unhelpful and it gives a link to file a bug report in Firefox's system, not Thunderbird's.

What happened?

The XPI was rejected with no helpful explanation, and I was told to file a bug report in the wrong place.

What did you expect to happen?

XPI acceptance.

Anything else we should know?

The attached ZIP file is actually the XPI of the code in question.

ses_tb-v1.0.zip

Installing Themes opens Not Found Page

"We're sorry, but we can't find what you're looking for." displayed when attempting to install a theme via ATN.

Need to decide what a good fix for this is.

spellcheckers/dictionaries are almost invisible in Thunderbird (too hard to reach)

This is from mozilla/addons/issues/733:

Describe the problem and steps to reproduce it:

I opened Thunderbird > Add-ons > Explore Addons > addons.mozilla.org (over one of the links there) -> search "english" or "deutsch"

What happened?

The search returned no result or just normal add-ons

What did you expect to happen?

I clicked in the navigation on
more -> Dictionaries & Language Packs -> The language(s) I wanted.
Now suddenly german/english dictionaries appear in the search.
Before they didn't for some reason.

I don't have the issue in Firefox, when I open the addon domain. (dictionaries are always part of the search results, when the search term fits)
But everytime I open the Page in Thunderbird (until I visited more -> language packs)

They are also way too hidden, considering how useful they are when writing mails.
It would be nice to see them listed next to themes and apps on the local "explore add-ons" page.

Also there are no backwards/forwards buttons when browsing on addons.mozilla.org in Thunderbird.

Regards,
Djfe

Anything else we should know?

I know these are partly Thunderbird bugs, but they are all related to addons.mozilla.org , so you and the Thunderbird team probably have to join efforts anyways, so I would rather report it here :)

thunderbird 52.9.1 gmail problems

thunderbird 52.9.1
with different email accounts give the following error when the inbox folder and any other folder of the Gmail account is clicked, is it Thunderbird
problem or something else.with 5 different email accounts loaded in Thunderbird 52.9.1(two outlook and three Gmail accounts)
it's only the Gmail accounts that this error is produced.in browsers all accounts are working ok.

thunderbird 52.9.1 error
Login Failed
Login to server imap.gmail.com failed.
Retry Enter New Password Cancel

click below

https://drive.google.com/open?id=1ArQLWO6TAfpGtnF0HJFOELdAFpzFEzXF

please help fix this error.
on the lower right corner of windows 7 taskbar thunderbird 52.9.1 gives the following message,
Alert from Account(Email address): please login via the web browser;
https://support.google.com/mail/accounts/answer/78754(Failure)
visiting the above link is not helpful in solving the problem.
what can be done to fix this error?
best wishes.

unable to download Featured Themes

Describe the problem and steps to reproduce it:

(Please include as many details as possible.) - **I'm trying to download featured themes. None will download.

What happened? I get this error message: We're sorry, but we can't find what you're looking for.

The page or file you requested wasn't found on our site. It's possible that you clicked a link that's out of date, or typed in the address incorrectly._
If you typed in the address, please double check the spelling.
If you followed a link from somewhere, please file an issue. Tell us where you came from and what you were looking for, and we'll do our best to fix it.
Or you can just jump over to some of the popular pages on our website.
Are you interested in a list of featured add-ons?
Do you want to search for add-ons? You may go to the search page or just use the search field above.
If you prefer to start over, just go to the add-ons front page.

What did you expect to happen? download and install new featured themes

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)

problem

Describe the problem and steps to reproduce it:

(Please include as many details as possible.)

What happened?

What did you expect to happen?

Anything else we should know?

(Please include a link to the page, screenshots and any relevant files.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.