thomascube / roundcube-elastic4mobile Goto Github PK

Trying to install on RC 1.4.10:

# composer require roundcube/elastic4mobile
Do not run Composer as root/super user! See https://getcomposer.org/root for details


  [InvalidArgumentException]
  Could not find a matching version of package roundcube/elastic4mobile. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (sta
  ble).

Today I updated to roundcube-1.4-rc2 and did also a php composer update.
I use the elastic4mobile plug-in to provide the new elastic skin to mobile phone users. Default skin is not elastic.

During testing I saw a flaw that I overlooked before: After logout on a mobile device the browser first returns to the default login page. When I reload this login page it changes again to the expected elastic login page.

If we have Preferences->Mailbox view->Layout set to Desktop for larry skin, after using mobile device it is set to Widescreen.

After installing the plugin, the following error message occurs:
PHP Fatal error: Class 'Mobile_Detect' not found in mydomain.com/plugins/elastic4mobile/elastic4mobile.php on line 19

When using elastic skin (by enabling this plugin) and have the folder list of the mailbox displayed the keyword list is laid over the folder names, making them inaccessible. Screenshot will follow.

This may be a problem specific to Kolab, as I'm using Kolab Groupware. It could be an issue with the Elastic skin as well, I just can't tell.

1. When the system default skin is not Elastic and user authentication fails, the skin will be reset to the system default. It is because of rcmail::$default_skin and what we do with it in kill_session().
2. The plugin MUST be put first on the plugins list otherwise the skin will be set too late and other plugins will use system/user skin instead. E.g. enable Archive plugin before elastic4mobile to see the problem.
3. $rcmail->output->set_env('skin', $skin); in the code is redundant, because set_skin() will do this.

I encountered these issues in my pwa plugin I'm working on. It also forces elastic skin in pwa mode similar to your plugin.

Maybe we could somehow improve core code to handle issue 1. and 2. more nicely. Something in plugin api that would allow to execute some code before plugin init? Also, rethink that rcmail::$default_skin.