thisissoon / angular-skrollr Goto Github PK

After upgrading from angular 1.4 to 1.5.8 the angular-skrollr stopped working. In fact, I am not sure whether it's the angular-skrollr itself or some transitive dependency that causes the problem.
Anyway, v1.5.8 support would be great. Currently, version 1.2 < 1.5 is supported.

UPDATE

Angular-skrollr does support Angular 1.5.8 as far as I can tell. I had a glitch in my configuration.
So, it's just the version info that should be updated.

It would be good to set a breakpoint where it's disabled under a certain size.

This could help: http://detectmobilebrowsers.com/

I was trying to set up my app.config based off of the Readme and after some frustration I got angular-skrollr integrated into my app. Despite the Readme stating that I needed to declare the package as snSkrollrProvider in my app.config, I could only get it to work with sn.skrollr.

Does the Readme have an error in it?

If an element's position is moved while scrolling or resizing the browser's window currently the element will still be animated using the keyframes calculated for the elements old position.

Example: using margin-top: -100px to move an element up the page will cause cause the data-bottom attribute styles to be initialised when the bottom of the element is 100px above the viewport instead of on the bottom of the viewport.

// 1. configure skrollr in your apps config
var myApp = angular.module('myApp', []);
myApp.config(["snSkrollrProvider", function(snSkrollrProvider) {
snSkrollrProvider.config({ smoothScrolling: true, ... });
}]);

This is the error message I get:
TypeError: object is not a function

Commenting this out, it works as it should. So the directive seems to work, just the configuration option fails.

Hi,
Greate job! I live much what you do!
I have question about your code. Im rly interested in your appoach. Why do you use .provider("snSkrollr") instead of use local controler in directive? You init the plugin on $document.read event?