thisissoon / angular-infinite-scroll Goto Github PK

Looking at the debounce input parameter, it looks like it should be used as the param for the debounce operator and be defaulted to 100 instead of 0.

CI doesn't appear to be configured correctly. Our open source code should always be correctly configured and built in a CI environment for others to use.

Thank you for your plugin, it's well, but when the offset=50, this scroll event will happen lots of time, and i wrote follow code to solve it, sometimes it is well, but if i scrolled fast, it's also a bug, how can i solve it perfectly?

` disabled = false;
onScrollModal() {
if(this.disabled == false){
this.scro();
this.disabled = false;
}
}

scro(){
        this.getIdentityGroupInfoNew(this.itemDataUuid, this.personType, this.identityGroup.length);
    this.disabled = true;
};`

Just one comment I think I would name the repo angular-infinite-scroll so it’s clear that it is a angular module and for consistency with our other modules.

I had to modify the code to get this to actually work. Instead of using the events file i am just listening to the window scroll event and grabbing the following properties

@HostListener('window:scroll', ['$event'])
public onScroll(): void {
    const height = document.documentElement.scrollHeight;
    const y = window.scrollY + window.pageYOffset;
    this.scroll$.next({ y, height });
}

Running in development launches the error message, but can run.

Running the build --prod fails and breaks.

node_modules@thisissoon\angular-infinite-scroll\src\app\infinite-scroll\shared\events.d.ts:2:34
Initializers are not allowed in ambient contexts.

change the line:
export declare const eventScroll = "scroll";

with line:
export declare const eventScroll: string;

to fixup the issue.

I run the build with success