Code Monkey home page Code Monkey logo

obsidian-harmonic's People

Contributors

gnopps avatar lilarest avatar thiews avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

obsidian-harmonic's Issues

Horizontal line not showing up in edit view

Hello, I like your theme but horizontal lines using --- are not showing up in edit view (but they do in read view. I couldn't find any style settings to address this. Also, is it possible to use the full window width in edit view (right now can only turn on for read view).

Thanks

Tags render improperly in live mode

I like this theme Very much! But I found some that in live mode something wrong with the tags.
image
And when I open the folder,it seems something wrong with render.
2022-07-21 at 09 23 39 - Blue Condor

turn off frameless?

Absolutely loving Harmonic theme. For some reason, it turns on frameless mode by default. I would like to have the titlebar back.

I've been working through css files and style settings. I've narrowed it down to the theme somehow because the titlebar is visible in other themes. Where can I go to toggle the titlebar back on?

H5 font-size cannot be customized

Hi !
When I try to change the h5 font-size in "Style Settings > Harmonic > Headings > Level 5", nothing happens. The h5 font-size is fixed to the default value "1.12em".
I've opened the dev console and it seems that you've just forgotten font-size: var(--h5); in the style of ".cm-header-5".
I could have made a pull request with the change but I thought it would be faster for you to just add the missing line rather than handling a pull request.

Thanks for this great theme !
Lilian πŸ™‚

Improvements for the README.md file

Hi @Thiews
I'm currently working on some improvements on the README.md file to make it more simple, readable and clean, you can see it on my forked repo here : https://github.com/LilianCr/Obsidian-Harmonic

I want your approval for something : Can I change images and functionalities presentation ? For example focus mode doesn't require any image, bold and pop could only be a small image in paysage. The goal of that is to make it shorter and easier for everyone that browse the functionalities of the theme πŸ™‚

Checkboxes

I've used SlRvb's CSS snippet for checkboxes with other themes, but it doesn't seem to play well with Harmonic. Is this something you can provide with your theme?
The snippet styles include these variations (and a lot more in fact):

  • [-]
  • [>]
  • [?]
  • [/]

Proposal to improve readability in preview mode

Hi !
Here is a proposal to improve readability in preview mode.
By default the margin-block-end and margin-block-start values are set to 1em for elements that are inside each preview section divs.
It conduces to huge line spacing between paragraphs and lists (where list is so far from its previous paragraph) for example, here is a picture :
harmonic_before

So, my proposal is to reduce the margin-block-end and margin-block-start values to 0.4em using this CSS rule :

div.workspace-leaf div.markdown-preview-sizer.markdown-preview-section > div > :not(h1, h2, h3, h4, h5, h6) {
    margin-block-start: 0.4em;
    margin-block-end: 0.4em;
}

EDIT : I used the :not() selector to exclude headers of this rule

And here is the result after this change :
harmonic_after

I tested this change on my own vault using CSS snippets today and for myself it is really more comfortable to read.

Lilian πŸ™‚

Proposal : Split the theme's CSS sheet in multiple CSS sheets

The goal is to allow easier collaboration on the theme :

  • People can work on different files without conflicts
  • The project is more accessible and easier to understand for new contributors
  • It's easier to maintain in the long term

But, is it possible with Obsidian ?
Have you tried it ? @Thiews
If we create a CSS file that imports several other CSS files, will Obsidian import them when someone downloads the theme ? Or does it only allow one CSS file ?

I'm going to open an issue on the Obsidian repo.
Lilian πŸ™‚

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.