thiennhan2310 / coderschool-assignment-2 Goto Github PK

Hi @thiennhan2310,
thanks for your submission. Let me leave some comment here.

Things you did well:

• You've used Go 1.12 Modules

Things to work on:

• Take attention to imports, use github.com/your-account/your-assignment
• When the swagger provided, easier to generate the code than write from scratch
• Try to ship your solution in a box. I mean no any information about how to run your application. All I get is an error messages related to imports and database connection. E.g.: it is not obvious, that I need to setup env vars.
• On the lab 2 we already used docker-compose and monitoring. You can leverage on that: https://gist.github.com/olivernadj/d78dd8fbd0d1e0a2f597d3c457165f70

Overall, please avoid last minute submission and try do ship a higher quality solution! Keep it up!