Code Monkey home page Code Monkey logo

bpost's People

Contributors

greenkeeper[bot] avatar haroenv avatar imgbotapp avatar thibmaek avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

haroenv

bpost's Issues

re-run the generator

There was a breaking bug in one of the previous version
I think it's a good idea to update your generator and re-run it.

Support both data for postal point & door-delivery

The json response will probably differ for door-delivery so needs to be checked when I can get a response from a door-delivery (should be soon). Adding to 0.2.0 for now, might change to 1.0.0 or 0.3.0

An in-range update of babel-cli is breaking the build 🚨

Version 6.23.0 of babel-cli just got published.

Branch Build failing 🚨
Dependency babel-cli
Current Version 6.22.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As babel-cli is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • ❌ continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Refactor API to instantiate first and use methods on that instance

In 0.1.0 and 0.1.1 all methods need to be called with an id passed to it each time:

import bpost from 'bpost';

const id = `323267009691651472`;

const a = bpost.getStatus(id);
const b = bpost.openingHours(id, 'monday');
const c = bpost. getPackageWeight(id);
…

Ideally the module would be created as an instance and then the id would be known to all methods:

import bpost from 'bpost';

bpost.setup(`323267009691651472`); // something like: setup, create, instantiate …

const a = bpost.getStatus();
const b = bpost.openingHours(`monday`);

Use GlobalFetch instead of axios

axios was used since there was an issue with GlobalFetch due to CORS requests not being supported API-side.

Preferably src/lib/composedFetch.js would use the following syntax (with a check for 200 status of course):

export default id =>
  fetch(`http://track.bpost.be/btr/api/items?itemIdentifier=${id}`)
    .then(res => res.data[0])
    .catch(e => console.error(e));

This would be ideal but failed because fetch did not complete due to the bpost api endpoint not setting Header: 'access-allow-control-origin'and thus not supporting CORS requests. Fetch offers a mode: 'no-cors' to return an opaque response but contains no data.

Note: also include a fetch polyfill for non supported environments like node. isormophic-fetch would work best.

An in-range update of babel-core is breaking the build 🚨

Version 6.23.1 of babel-core just got published.

Branch Build failing 🚨
Dependency babel-core
Current Version 6.23.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As babel-core is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • ❌ continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

Version 3.13.0 of eslint just got published.

Branch Build failing 🚨
Dependency eslint
Current Version 3.12.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • ❌ continuous-integration/travis-ci/pr The Travis CI build failed Details
Release Notes v3.13.0
  • cd4c025 Update: add fixer for no-extra-label (#7840) (Teddy Katz)
  • aa75c92 Fix: Ensure prefer-const fixes destructuring assignments (fixes #7852) (#7859) (Teddy Katz)
  • 4008022 Chore: Refactor to use ES6 Classes (Part 3)(refs #7849) (#7865) (Gyandeep Singh)
  • c9ba40a Update: add fixer for no-unneeded-ternary (#7540) (Teddy Katz)
  • dd56d87 Update: add object-shorthand option for arrow functions (fixes #7564) (#7746) (Teddy Katz)
  • fbafdc0 Docs: padded-blocks never case (fixes #7868) (#7878) (alberto)
  • ca1f841 Fix: no-useless-return stack overflow on loops after throw (fixes #7855) (#7856) (Teddy Katz)
  • d80d994 Update: add fixer for object-property-newline (fixes #7740) (#7808) (Teddy Katz)
  • bf3ea3a Fix: capitalized-comments: Ignore consec. comments if first is invalid (#7835) (Kevin Partington)
  • 616611a Chore: Refactor to use ES6 Classes (Part 2)(refs #7849) (#7847) (Gyandeep Singh)
  • 856084b Chore: Refactor to use ES6 Classes (Part 1)(refs #7849) (#7846) (Gyandeep Singh)
  • bf45893 Docs: Clarify that we only support Stage 4 proposals (#7845) (Kevin Partington)
  • 0fc24f7 Fix: adapt new-paren rule so it handles TypeScript (fixes #7817) (#7820) (Philipp A)
  • df0b06b Fix: no-multiple-empty-lines perf issue on large files (fixes #7803) (#7843) (Teddy Katz)
  • 18fa521 Chore: use ast-utils helper functions in no-multiple-empty-lines (#7842) (Teddy Katz)
  • 7122205 Docs: Array destructuring example for no-unused-vars (fixes #7838) (#7839) (Remco Haszing)
  • e21b36b Chore: add integration tests for cache files (refs #7748) (#7794) (Teddy Katz)
  • 2322733 Fix: Throw error if ruletester is missing required test scenarios (#7388) (Teddy Katz)
  • 1beecec Update: add fixer for operator-linebreak (#7702) (Teddy Katz)
  • c5c3b21 Fix: no-implied-eval false positive on 'setTimeoutFoo' (fixes #7821) (#7836) (Teddy Katz)
  • 00dd96c Chore: enable array-bracket-spacing on ESLint codebase (#7830) (Teddy Katz)
  • ebcae1f Update: no-return-await with with complex return argument (fixes #7594) (#7595) (Dalton Santos)
  • fd4cd3b Fix: Disable no-var autofixer in some incorrect cases in loops (#7811) (Alan Pierce)
  • 1f25834 Docs: update outdated info in Architecture page (#7816) (Teddy Katz)
  • f20b9e9 Fix: Relax no-useless-escape's handling of ']' in regexes (fixes #7789) (#7793) (Teddy Katz)
  • 3004c1e Fix: consistent-return shouldn't report class constructors (fixes #7790) (#7797) (Teddy Katz)
  • b938f1f Docs: Add an example for the spread operator to prefer-spread.md (#7802) (#7804) (butlermd)
  • b8ce2dc Docs: Remove .html extensions from links in developer-guide (#7805) (Kevin Partington)
  • aafebb2 Docs: Wrap placeholder sample in {% raw %} (#7798) (Daniel Lo Nigro)
  • bb6b73b Chore: replace unnecessary function callbacks with arrow functions (#7795) (Teddy Katz)
  • 428fbdf Fix: func-call-spacing "never" doesn't fix w/ line breaks (fixes #7787) (#7788) (Kevin Partington)
  • 6e61070 Fix: semi false positive before regex/template literals (fixes #7782) (#7783) (Teddy Katz)
  • ff0c050 Fix: remove internal property from config generation (fixes #7758) (#7761) (alberto)
  • 27424cb New: prefer-destructuring rule (fixes #6053) (#7741) (Alex LaFroscia)
  • bb648ce Docs: fix unclear example for no-useless-escape (#7781) (Teddy Katz)
  • 8c3a962 Fix: syntax errors from object-shorthand autofix (fixes #7744) (#7745) (Teddy Katz)
  • 8b296a2 Docs: fix in semi.md: correct instead of incorrect (#7779) (German Prostakov)
  • 3493241 Upgrade: strip-json-comments ~v2.0.1 (Janus Troelsen)
  • 75b7ba4 Chore: enable object-curly-spacing on ESLint codebase (refs #7725) (#7770) (Teddy Katz)
  • 7d1dc7e Update: Make default-case comment case-insensitive (fixes #7673) (#7742) (Robert Rossmann)
  • f1bf5ec Chore: convert remaining old-style context.report() calls to the new API (#7763) (Teddy Katz)
Commits

The new version differs by 43 commits .

  • 8571ab8 3.13.0
  • d54e0c1 Build: package.json and changelog update for 3.13.0
  • cd4c025 Update: add fixer for no-extra-label (#7840)
  • aa75c92 Fix: Ensure prefer-const fixes destructuring assignments (fixes #7852) (#7859)
  • 4008022 Chore: Refactor to use ES6 Classes (Part 3)(refs #7849) (#7865)
  • c9ba40a Update: add fixer for no-unneeded-ternary (#7540)
  • dd56d87 Update: add object-shorthand option for arrow functions (fixes #7564) (#7746)
  • fbafdc0 Docs: padded-blocks never case (fixes #7868) (#7878)
  • ca1f841 Fix: no-useless-return stack overflow on loops after throw (fixes #7855) (#7856)
  • d80d994 Update: add fixer for object-property-newline (fixes #7740) (#7808)
  • bf3ea3a Fix: capitalized-comments: Ignore consec. comments if first is invalid (#7835)
  • 616611a Chore: Refactor to use ES6 Classes (Part 2)(refs #7849) (#7847)
  • 856084b Chore: Refactor to use ES6 Classes (Part 1)(refs #7849) (#7846)
  • bf45893 Docs: Clarify that we only support Stage 4 proposals (#7845)
  • 0fc24f7 Fix: adapt new-paren rule so it handles TypeScript (fixes #7817) (#7820)

There are 43 commits in total. See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Use ES6 import for axios instead of require

Breaks the UMD build.
Axios exports the module using keys which contain reserved js keywords which makes it error with bundling trough rollup. Issue is currently not easily fixable should become obsolete once #17 is fixed.

Support multilanguage data returns

The JSON response has some keys for multilanguage usage (nl, fr, en).
Could be implemented by requiring an argument to the constructor for language settings.
Keep the default English.

example:

import bpost from 'bpost';

bpost(`323267009691651472`, 'nl');

Opt out of hooks when testing on CI

Due to the bpost firewall blocking the error expect()s Travis will fail currently.

It only needs to run npm run test:ci because otherwise it will hit the API with too many exceptions. When installing with yarn though, the prepublish hook is triggered and runs npm run lint:build:test before running the travis run command.

An in-range update of rollup is breaking the build 🚨

Version 0.41.5 of rollup just got published.

Branch Build failing 🚨
Dependency rollup
Current Version 0.41.4
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As rollup is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • ❌ continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
Commits

The new version differs by 29 commits .

There are 29 commits in total. See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

An in-range update of babel-core is breaking the build 🚨

Version 6.20.0 of babel-core just got published.

Branch Build failing 🚨
Dependency babel-core
Current Version 6.18.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As babel-core is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

  • ❌ continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details

  • ✅ codecov/project 69.62% (+0.00%) compared to dc06e8f Details

  • ✅ codecov/patch Coverage not affected. Details

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Fetch response over https

The api has a valid signed SSL certificate so the baseUrl for the fetch should be: https://track.bpost.be/btr/api

Add support for return to sender 

"processOverview": {
"activeStepTextKey": "RETOUR_DELIVERED",
"textKey": "step.text.retour.delivered",
"alert": false,
"processSteps": [
{
"name": "return_to_sender",
"status": "completed",
"label": {
"main": "returnToSender"
},
"knownProcessStep": "RETURN_TO_SENDER"
},
{
"name": "processing",
"status": "completed",
"label": {
"main": "processing",
"detail": "byBpost"
},
"knownProcessStep": "PROCESSING"
},
{
"name": "out_for_delivery",
"status": "completed",
"label": {
"main": "onTheWay",
"detail": "towardsSender"
},
"knownProcessStep": "ON_THE_WAY_TO_SENDER"
},
{
"name": "delivered",
"status": "active",
"label": {
"main": "returned",
"detail": "toSender"
},
"knownProcessStep": "DELIVERED_TO_SENDER"
}
]

Possible bug for splitting requestedDeliveryMethod

"requestedDeliveryMethod": "HOME", in the API response might pose a problem for:

export const deliveryMethod = id => composedFetch(id)
  .then(data => data.requestedDeliveryMethod.toLowerCase().split(`_`));

in src/lib/methods/packageInfo.js

Reduce the size for lodash dependency

Below screenshot shows that lodash currently installs the full 4.8MB module and only filter and find are used. Need to find a better way to include lodash as a dependency.

screenshot 2016-11-20 00 42 30

Write documentation

Before releasing 0.1.1 make sure to write up documentation on each method and how to use this module.

Since this is low-level preferably in README.

Create .github files

oneliner: mkd .github && touch PULL_REQUEST_TEMPLATE.md ISSUE_TEMPLATE.md

Add in content individually

An in-range update of eslint is breaking the build 🚨

Version 3.15.0 of eslint just got published.

Branch Build failing 🚨
Dependency eslint
Current Version 3.14.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • ❌ continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
Release Notes v3.15.0
  • f2a3580 Fix: no-extra-parens incorrect precedence (fixes #7978) (#7999) (alberto)
  • d6b6ba1 Fix: no-var should fix ForStatement.init (#7993) (Toru Nagashima)
  • 99d386d Upgrade: Espree v3.4.0 (#8019) (Kai Cataldo)
  • 42390fd Docs: update README.md for team (#8016) (Toru Nagashima)
  • d7ffd88 Chore: enable template-tag-spacing on ESLint codebase (#8005) (Teddy Katz)
  • f2be7e3 Docs: Fix typo in object-curly-newline.md (#8002) (Danny Andrews)
  • df2351a Docs: Fix misleading section in brace-style documentation (#7996) (Teddy Katz)
  • 5ae6e00 Chore: avoid unnecessary feature detection for Symbol (#7992) (Teddy Katz)
  • 5d57c57 Chore: fix no-else-return lint error (refs #7986) (#7994) (Vitor Balocco)
  • 62fb054 Chore: enable no-else-return on ESLint codebase (#7986) (Teddy Katz)
  • c59a0ba Update: add ignoreRestSiblings option to no-unused-vars (#7968) (Zack Argyle)
  • 5cdfa99 Chore: enable no-unneeded-ternary on ESLint codebase (#7987) (Teddy Katz)
  • fbd7c13 Update: ensure operator-assignment handles exponentiation operators (#7970) (Teddy Katz)
  • c5066ce Update: add "variables" option to no-use-before-define (fixes #7111) (#7948) (Teddy Katz)
  • 09546a4 New: template-tag-spacing rule (fixes #7631) (#7913) (Jonathan Wilsson)
Commits

The new version differs by 17 commits .

  • 8ea98f9 3.15.0
  • 77b5cb7 Build: package.json and changelog update for 3.15.0
  • f2a3580 Fix: no-extra-parens incorrect precedence (fixes #7978) (#7999)
  • d6b6ba1 Fix: no-var should fix ForStatement.init (#7993)
  • 99d386d Upgrade: Espree v3.4.0 (#8019)
  • 42390fd Docs: update README.md for team (#8016)
  • d7ffd88 Chore: enable template-tag-spacing on ESLint codebase (#8005)
  • f2be7e3 Docs: Fix typo in object-curly-newline.md (#8002)
  • df2351a Docs: Fix misleading section in brace-style documentation (#7996)
  • 5ae6e00 Chore: avoid unnecessary feature detection for Symbol (#7992)
  • 5d57c57 Chore: fix no-else-return lint error (refs #7986) (#7994)
  • 62fb054 Chore: enable no-else-return on ESLint codebase (#7986)
  • c59a0ba Update: add ignoreRestSiblings option to no-unused-vars (#7968)
  • 5cdfa99 Chore: enable no-unneeded-ternary on ESLint codebase (#7987)
  • fbd7c13 Update: ensure operator-assignment handles exponentiation operators (#7970)

There are 17 commits in total. See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.