thewilley / text2book Goto Github PK

The code is quite hard to follow as it is now. Refactoring it might be a good idea, splitting functions into multiple files, changing variable names, etc.

The same goes for the README file, as it's rather cluttered.

The webpage strips out quotation marks and apostrophes (" and ')

Due to a strange error where I couldn't log in for no apparent reason an admin friend of mine used text2book's commands function to put some books in the game for me.

However they both started and ended up with square brackets and for some reason these square brackets ended up in the title, instead of in the text. It has also eaten a quotation mark.

I am aware this is very much an edge case

For example, this one is supposed to start with a [

and end with a "]

and the title is not supposed to contain [0]

Sorry about this but it seems like it doesn't always take into account the space taken up by a line break when splitting books up. In the most recent lore book I made it put in one line's worth more text than actually fit in a page that had a line break in the middle.

Presently, a numerical identifier in the form of [n] is appended to the book title during command generation to facilitate differentiation among generated books. Nevertheless, users may desire the option to exclude automatic numbering from their book titles, and this capability should be made available to them.

Currently the amount of lines per page is hard-coded to 14, since this is the maximum amount of lines per page. Allowing the user to adjust this value could be useful if they for some reason would not want to use the entire page.

The program generates the commands correctly, however, java doesnt display some words at the end of pages sometimes, though the same words that arent showing on java show up on bedrock

also if you check my profile i have forked it for 50 page limit so it works with bedrock (this took me a hour to find the simple line XD)

When generating a large amount of text, it can take a while for React to create all textboxes which contains the app results. Pagination would be an easily solution to reduce loading times.

It seems to replace line breaks with a space, which is an issue when you want a line break (e.g. in a recipe book or something).

Users may want to extract all generated commands / text into a text file, e.g, for sharing.

As outlined in #12, the bedrock version of Minecraft only supports 50 pages, while the java version supports 100. A toggle should be added to to switch to either "bedrock mode" or "java mode" in order to support both versions.

so i'm trying to go on the text2book website, but my browser (opera gx) keeps giving me errors, saying the website is inaccessible. is there any reason for this ?

If the "Generate Text" option is checked, and the user tries to press "Generate" while no author or title it entered, the app will strait up refuse to generate anything. This is unintentional, as neither an author or title is needed to generate text, but it is required to generate a command.

After further research, it seems like the testing methodology was created in vain, as a small yet important detail was glanced over. The testing document explains that we use the data from a Minecraft world to get the contents of a book within a players inventory. The assumption was that the text displayed in the book GUI would be the same within the .dat file located in the world folder. However, the problem is that the book contents is not truncated within the .dat file, it is done on demand when opening the book GUI. This can even be confirmed when looking at Minecraft's source code:

this.cachedComponents = itextcomponent != null ? GuiUtilRenderComponents.splitText(itextcomponent, 116, this.fontRenderer, true, true) : null;

Essentially the text is split into an array of strings in such a way that they'll fit on a single line on a page. Looking in the .dat file itself we can also confirm that the text is in fact not truncated beforehand, as string which should be way out of page bounds are still stored:

Item 6 contains a very long string

The book GUI removes the overflowing text

Unless we modify the Minecraft source code, there is basically nothing that can be done about this. The test is essentially useless, as it effectively compares its own output with itself, which always yields a positive test result. I have made some attempts at a solution (including converting the source code to javascript) but to no avail. The testing methodology may have to be changed if a solution cannot be found. I won't put too much time into this if the solution turns out to be more work than worth.

When there are a lot of items in the list (see image), you have to constantly find the row you were on last after copying, which is just wasted time. Add a marker (i.e check-mark) which tells the user which one they copied last.

          i am getting an error saying ''website inaccessible, this website took too long to responds''

yes, i am using the right url
it isn't working in google chrome either

Originally posted by @BIock64 in #16 (comment)