Code Monkey home page Code Monkey logo

smooth-opentok's People

Contributors

nicholaswmin avatar

Watchers

 avatar  avatar  avatar  avatar

smooth-opentok's Issues

v1 Todos

Issues and todos

  • Make sure all console warnings are taken care of.
  • Toggling video on/off does not actually turn off the camera (the hardware camera light stays on).
    • It merely stops the video publishing. This is undesirable. We want the camera (and it's on/off light) to be off when the video is not toggled on.
    • .joinCall starts the camera, even with publishVideo: false. This shouldn't happen.
  • Find a way to unit test the components. Perhaps mock the OT object? Or do tests with the actual OT object? Ask around.

Cannot unit-test screensharing without HTTPs

Web-Component-Tester, does not seem to have an option to run tests under HTTPS, hence any tests involving the Chrome screensharing extension fail. OT.checkScreenSharingCapability() always returns extension:installed as false under HTTP.

An (almost) working strategy:

  • Have 2 WCT configuration files, one for regular tests (w/o extensions) and one with it.
  • In test/run.js we allowed running spawnWCT with arguments:
    • 1st describe('without extension'), runs spawnWCT passing the WCT config. file that doesn't
      pass flags to install the extension.
    • 2nd describe('without extension'), runs spawnWCT and passes the WCT config. file that
      passes special flags to install the extension.

Example command to run WCT with specified config. file:

$ wct --configFile=wct.conf-screen-ext-installed.json

...and an example wct.conf-screen-ext-installed.json, that
auto-loads the extension:

{
  "expanded": true,
  "suites": ["test/screen-ext-installed/*.html"],
  "plugins": {
    "local": {
      "browsers": [
        "chrome"
      ],
      "browserOptions": {
        "chrome": [
          "auto-select-desktop-capture-source='Entire screen'",
          "use-fake-device-for-media-stream",
          "use-fake-ui-for-media-stream",
          "system-developer-mode",
          "--allow-http-screen-capture",
          "load-extension=./extensions/chrome/ScreenSharing"
        ]
      }
    }
  }
}

The strategy (almost) works since it fails due to the lack of HTTPs.

Need to find a way to run $ wct with HTTPs for this to continue.

Questions asked:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.