thepixeldeveloper / kohana-sitemap Goto Github PK

I think it will be great if module automatically save / update url data in sitemap.xml file and make it compressed copy.

It would be great if we could include an XSL file to enhance our sitemaps, should a human want to view it, a la http://www.zeldman.com/sitemap.xml

Propose to use

throw new Sitemap_Exception($message, $variables, $code);

Should be passing in a constant to $code like:

Sitemap::INVALID_ARGUMENT

references to valid:: class in MODPATH/sitemap/classes/kohana/sitemap/url.php [ 22 ] don't work as Valid has become Validate.

Just replace the two uses of Valid:: with Validate:: and it works a charm!

Causes validation errors with Google Webmaster Tools.

Row 23 in classes/kohana/sitemap/video.php has a spelling error: thumnail_ instead of thumbnail_loc

Perhaps it would be good form to generate some defaults for certain fields, like set_last_mod, to use the date of the cache being generated, if a specific value was not supplied?

How about updating the urlset tag to something a bit more recent like:

<urlset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">

Is there any documentation on how to install this?