theonlyzac / sly-string-toolkit Goto Github PK

If the strings or the assembly code being patched in is too long, it will lead to unusual behavior or game crashes.

Planned solution

• Add an additional assembly function that performs a sanity check to ensure there are enough null bytes to write all the strings/machine code bytes.
• Add a conditional to the final pnach that only writes the bytes if the sanity check passed.

The script uses whatever you put as the custom offset for a string as the first part of the pnach line that writes it, so if you put an address like 3C8800, it writes

patch=1,EE,3C8800,extended,XXXXXXXX

instead of

patch=1,EE,203C8800,extended,XXXXXXXX`

Temporary fix is to include the 20 at the start of the offset until the pnach generation is updated to properly prefix the 2 code before the offset.

You should have some control over the the address where the asm code/strings are injected.

Generating and loading a PAL mod pnach makes some/all menu backgrounds transparent.

Some characters, such as ®️, are being encoded incorrectly and are showing up with extra extraneous characters in game.

Two pnaches can be compatibly if they both write to the same address, but both writes are quantified by conditional checks that are mutually exclusive. The check_pnach_compay.py script ignores the conditional checks and only looks at the 32-bit writes in the pnach, so it will sometimes report that two pnaches are incompatible when in reality they are.