thelocomotion / gloriousprotonmanager Goto Github PK

If you enable the expand_x when making your Multline element, it will automatically size itself, in the X-direction, to fit the container/window.

Inserting 7-22 works (with no progress just need to wait), but inserting GE-Proton7-22 just crashes the app. This is interesting, as some other invalid values seems to trigger a warning message about invalid input.

Using GloriousProtonManager-0.70.3-py3-none-any.whl

• Convert to a Python module to make it Object Oriented: https://packaging.python.org/en/latest/tutorials/packaging-projects/ (Or check out my sent aws-connector example)
• https://github.com/thelocomotion/GloriousProtonManager/blob/main/glorious_proton_manager.py#L11 Setting a home variable is something that should go into the init method, in the init. The init method is part of a Class and is called everytime you initiate the Class. Which works for this kind of variable setting, variables in the init method can be used everywhere in the Class. (Read upon class vs instance variables: https://medium.com/python-features/class-vs-instance-variables-8d452e9abcbd#:~:text=Class%20variables%20are%20shared%20across,surprising%20behaviour%20in%20our%20code
• https://github.com/thelocomotion/GloriousProtonManager/blob/main/glorious_proton_manager.py#L16 You’re using the requests call twice. If you’re using something twice, put it in a separate method and call it by adding a variable into it. In this case create a method that does a requests.get, and insert the URL to get in the method as a variable.
• https://github.com/thelocomotion/GloriousProtonManager/blob/main/glorious_proton_manager.py#L23 I think unconsciously you’re doing a pretty good thing here if you consider this: When creating functions, you always need to limit what the function returns. This is a basic principle of object oriented coding. So by using the If and Else here you’re limiting what comes out of it. You can extend this function by adding the return statement. (read upon: https://realpython.com/python-return-statement/) . So try to use this as much as possible, use a try catch for special functions like http gets, and use if else for creating a ‘good’ and ‘bad’ outcome of your function. That way it would be also much easier to create unit tests, which brings to my next topic!
• I’m missing unit tests: https://docs.python.org/3/library/unittest.html (but you should reconsider if it’s really needed for this tool, it certainly pushed you to prevent writing broken or bad code)
• Separate the python functions from the command line code (PySimpleGUI), in a Python package the functions go into the lib or src folder and the command line code (PySimpleGUI) would then go into the bin folder.
• https://github.com/thelocomotion/GloriousProtonManager/blob/main/glorious_proton_manager.py#L19 this dict is something you would want to check in a method, so even see if there is a [1] (second array entry) and then pull the browser_download_url as this might not always be the case. You can also use scan functions to check for dict key values in a big dict and put a try and catch around or at least an if/else.

Was great to see you proudly post this work!

You've got a GUI, a rare thing in Python. Users would love to see it. How complex/simple your GUI is doesn't matter. Just having one is the big deal. Double-clicking an icon versus opening a command-line prompt opens up your program to the world as a whole.

I saw you mentioned finding out about this Qt-based project later:
https://github.com/DavidoTek/ProtonUp-Qt

Note that they dropped a screenshot in their readme. One huge benefit you've got is that by using PySimpleGUI, you're using tkinter, which is built-into Python and can be used commercially without problems... Qt, gets complicated.

Congrats on your creation!