thejettdurham / gamesmenu Goto Github PK

The hardcoding of the data means the app is inflexible to changing data. Reading the data from a file can make the ingest process more flexible

If the app were to be maintained for any length of time, refactoring the monolithic reducer function would be necessary.

As currently implemented, the renderer for each active and confirmed selection runs every time the component is re-rendered. For a large list of confirmed selections, this could result in performance degradation.

The only action taken on confirmed actions is deletion, so the representation for them can be resolved at confirmation time closer to it's visual representation with no loss of information. This can also enable displaying a sum of total prices across all confirmed selections.

Shame on me! This would be the first issue I would address if the app were to be deployed and maintained.