Search for synonyms! Important! about hpo-web HOT 19 CLOSED

@iimpulse we still need to implement this

from hpo-web.

@drseb @pnrobinson This has been added. Please test. It really only works well getting closer to the synonym.

from hpo-web.

Hi, this doesn't work for me. I tried searching with the synonyms of https://hpo.jax.org/app/browse/term/HP:0000240 and get no results if I search e.g. for "head size" or "cranium size"

from hpo-web.

from hpo-web.

Entering the exact synonym, leads to wrong results. Am I doing something wrong?

from hpo-web.

@drseb Hey so I've done some testing it looks like there is an issue with how many requests we are sending off at a time. Which then lags and causes the result to show what you are seeing. I've put a fix in a PR just waiting on approval.

from hpo-web.

This is still not working. https://hpo.jax.org/app/browse/search?q=pins%20and%20needles&navFilter=all

from hpo-web.

@jmcmurry @drseb Sorry. My first pass was not good enough. Messing around with the ORM is time crunching and inefficient. I've moved to raw sql and just need to add some testing and I'll release. Looks like our synonyms are being improperly mapped to terms as well. So I'll have to look at that.

from hpo-web.

Thanks for working on it. @kshefchek is there anything you've already built that could help them?

from hpo-web.

Happy to help but it sounds like @iimpulse has it worked out

from hpo-web.

Hi guys, I've deployed. Please help me test this functionality! @jmcmurry @drseb @pnrobinson

from hpo-web.

This is a big improvement however is still out of step with prevailing standards. The string that shows up in the autocomplete menu needs to be the one that matches the search string, whether or not the match is the label.

See for instance:

should instead be

Does this make sense?

from hpo-web.

The partial string match highlighting in autocomplete is something we are also struggling with on the Monarch side. cc: @kshefchek

from hpo-web.

I did some digging some time ago and determined with our current tokenizer/filter setup we could not do partial word highlighting. We could adjust things but it didn't seem worth the effort. https://issues.apache.org/jira/browse/SOLR-7926 Also possible this is fixed in solr 7.

from hpo-web.

I might be able to pull this off with a clever join. However there could be alot of underlying hidden gotcha's with this, particularly this one..searching synonym for "pins" truly returns:

TERM *** SYNONYM
Hypogonadotrophic hypogonadism *** Low gonadotropins (secondary hypogonadism)
Increased circulating gonadotropin level *** Elevated serum gonadotropins
Increased circulating gonadotropin level *** Elevated gonadotropins
Paresthesia *** Pins and needles feeling

In this scenario, we actually have two matching synonyms for the same term. Remember this is MYSQL. There could be downstream filters after we return from the database, but those rules would have to be clearly defined.

from hpo-web.

If the query string matches more than one synonym, I'm not as fussy about which one to display. I would default to the shorter one though.

from hpo-web.

The current implementation is limited because of https://stackoverflow.com/questions/641407/javascript-negative-lookbehind-equivalent

Once this is supported across all browsers it won't be as limited. I'm testing a bit further to make sure we don't have any large bugs.

from hpo-web.

Why not keep things simple and go

if ( (! string.startsWith("ABC") ) && ( string.matches("My awesome regex")) {
  do something cool here
}

from hpo-web.

I think this is now working very nicely and will close this issue! Please reopen with any specific items that many remain if necessary!

from hpo-web.