theiterators / sealed-monad Goto Github PK

Hi,

It would be great to have .void as alias to .map(_ => ())

The project is currently undocumented - adding descriptions, tips and example (typechecked) usages to functions exposed to the user will be extremely helpful.

https://github.com/olafurpg/sbt-ci-release

https://github.com/scalameta/mdoc

I've came across couple of methods missing, e.g.:

• noValueOr
• noValueOrF
• flatTapWhenNot
• ensureNotF

We could use an alternative to this function, preferably named ensureF:

def ensure[ADT](pred: A => Boolean, orElse: => ADT): Sealed[F, A, ADT]     = seal[ADT].ensure(pred, orElse)

This could cut off some boilerplate compared to the following usage of attemptF:

private def setFailed(obj: SomeObj): F[Result] = ???

private def ensureSomething(obj: SomeObj): StepF[Unit] =
    transactor
      .execute(someDbCall())
      .attemptF[Result, Unit] {
        case list if !list.exists(_.id != obj.id) => F.pure(Right(()))
        case _ =>
          setFailed(obj)
            .map(result => Left(result))
      }

versus potential ensureF:

private def ensureSomething(obj: SomeObj): StepF[Unit] =
    transactor
      .execute(someDbCall())
      .ensureF(!_.exists(_.id != deployment.id), setFailed(obj))

Similar to #188

https://github.com/release-drafter/release-drafter

Current documentation lives under: https://theiterators.github.io/sealed-monad/ and is very limited. Ideally it should:

• show case some beautiful code example on the intro page,
• tell more about ADT-centric error handling,
• show more use cases,
• main GH page (https://github.com/theiterators/sealed-monad) could feature more details from the docs,
• travis badge doesn't work anymore,
• logo should be updated.

Hi,

I have encountered an inconsistency with the order of type parameters in the attemptF method within which could potentially cause confusion.

final class SealedFAOps {
  def attemptF[ADT, B]
}

// When using attemptF:
attemptF[FooResult, Unit]

sealed trait Sealed {
  def attemptF[B, ADT1 >: ADT]
}

// When using attemptF:
attemptF[Unit, FooResult]

...or see if it's possible.

As in title, not sure if "effectful" ensure is a good idea 🤷