the-ditanian-fleet / waitlist Goto Github PK

• fix preexisting unit tests
• create unit tests that are missing

PR #175 will break our Dockerfile that builds the backend code. This will happen because the new PR (175) removes sqlite; however, the Dockerfile relies on this engine.

It could be worth spending some time redesigning the Dockerfile to build production-ready images, this could be tied into GHCR and GH Actions so we can automate builds when code is pushed to main. However, I do not have the time to do this at the moment.

• start hours counting at 25 in fleet
• only count ongrid wing in this number - not needed
• only count doctrine ships / hulls

• Add it as a tag that HQ-FC can give
• Make it show on x up
• Add it to badges guide
• Unfuck acl so they aren't all linked or whatever
• Make it so that INACTIVE cannot be invited by trainee fc (might as well do the same with nestors without L badge at the same time)
• probably something else i'm missing rn

From reference implementation of sse-server:
https://github.com/the-ditanian-fleet/sse-server/blob/main/example/app.py

# Private and public SSE urls are different because of docker-compose
private_sse_url = "http://sse-server:8000"
public_sse_url = "http://localhost:8000"

Currently there is only one sse-server url pulled and used. This results in backend not directly connecting to sse-server container network and it makes local docker dev setups a PITA. Maybe it is possible to have two sse-server urls like in the python example application?

The URL for the Badge Guide has changed from /guide/badges to /badges, visiting the old URL will result in the user being shown a 404 page.

The following pages have outdated links:

• First Fleet Guide
• Upgrade guide (under heading "Elite")

There are two options to fix this. Either we update the URLs in the aforementioned guides to the new URL, or we update the router and navbar files so that they go back to using /guides/badges. This would probably be my preferred as it means our URL structure for guides is consistent.

Let me know what option you want and I'll open a PR.

• when clicking on starter basic elite etc for each ship

It is unclear how to install this project. I got the frontend and backend container running and now it complains about not having access to the db.

Is it possible to provide something like a docker-compose file for easy installation?

Add an ESI-UI show info button to the pilot's profile page for FCs.

Hi,

i recently stumbled upon this cool project and tinkered a little bit with it in order to get it running with docker-compose. I think i succeeded in that and wrote some basic docs here https://github.com/fleischsalatinspace/waitlist/tree/add-docker-compose, but it was a bit of a hit and miss without documentation, especially regarding the sse-server. Do you plan on writing some docs? i know this is some kind of "private" project. Do you accept PRs?

Also would be interesting to know how you run this in production? k8?

Anyway thank you for this cool project