thatgibbyguy / ply Goto Github PK

The project is somewhat out of date and would have to be refactored to use the latest gulp. Therefore the readme should include what you'll need to run this project as a standalone:

• node v 10 or below
• gulp v 3.9 or below

Currently the navigation component treats nested spans as a designation for an active state. This introduces an issue where a user would be forced to override this styling to get expected behavior. Instead, require span elements to also have a class that designates them as being active.

We should remove all reliances on pixels from all variables. This 4px value could instead be .25em and achieve the same result.

Developing with helper classes has become an excellent use of ply.

Simply pulling and using ply iso or complete, one should be able to simply use something like the following:

<button class="btn margins--margin-bottom">ClickyBoy</button>

To show a button with some margin below it to leave some breathing room before the next bit of content starts.

However, The .btn has a margin: 0 which overrides this simple helper class.

Proposed solutions:

1. Remove margin: 0 from the .btn selector.
2. Remove the button.btn selector
3. Only use button, input[type="button"], etc selectors for bg, border, radius, and not for margin: 0
4. Some kind of combination of the above.

Thoughts?

Development needs to be versioned and released and push to master.

As the title says, let's create an npm script that will run all the gulp tasks needed for generating all the distribution css.

We can call it buildDis or something.

At line 28 we are selecting all children span elements of navbar. Let's make that a direct decendent.

As the title says, this repo is essentially way out of date. Should be updated for manual compiling to work. Otherwise, you have to use outdated versions of node.

File: src/scss/components/_grid.scss

For small-desktop breakpoints, in the github repo, @media (min-width: $breakpoint-small-desktop) { is used, but in the npm package, max-width is used.

This causes an issue where, for example, any cell using both small-desktop-unit-** and large-phone-unit-** always takes the small-desktop number, regardless of screen size.

Proposed fix: update npm package with latest code in github repo.