textlint-rule / textlint-rule-date-weekday-mismatch Goto Github PK

chrono-node CVE-2021-23371: https://snyk.io/vuln/SNYK-JS-CHRONONODE-1083228

I would like to update chrono-node to v2.2.4 or higher, due to a vulnerability about a DoS attack issue.

Chrono-node v2 has breaking changes, which is critical for this textlint rule.

For Users

• Chrono’s default now handles only international English. While in the previous version, it tried to parse with all known languages.
• The current fully supported languages are en, ja, and fr (de and pt are partially supported). Other languages from v1 (nl and zh) are under development.
  https://github.com/wanasit/chrono#whats-changed-in-the-v2

So, following things have to be done to update chrono-node to v2.x:

• Change the code to use the chrono-node v2.x correctly with locale support.
• Drop the support for es (Spanish) that is not supported by chrono-node v2.x.
• (Possibly) Drop the support for auto language detection and user will have to choose a language in textlintrc file.

(If you find it's not necessary, it's fine to just close this issue.)
（一旦Issueを立てましたが、必要ないようであればそのまま閉じていただいて構いません。）

I'm implementing a plugin that applies textlint fixes, and noticed that the range is being incorrectly computed.

See the example below:

$ echo '2021-07-02 (Thursday)' | textlint --format json --config samples/.textlintrc.json --stdin --stdin-filename file.md | jq
[
  {
    "messages": [
      {
        "type": "lint",
        "ruleId": "date-weekday-mismatch",
        "message": "2021-07-02 (Thursday) mismatch weekday.\n2021-07-02 (Thursday) => 2021-07-02 (Friday)",
        "index": 12,
        "line": 1,
        "column": 13,
        "severity": 2,
        "fix": {
          "range": [
            12,
            18
          ],
          "text": "Friday"
        }
      }
    ],
    "filePath": "<markdown>"
  }
]

The range should be within 8 characters (Thursday), instead of 6. If I apply the suggested range, I'll end up with Fridayay.

On yarn install I get an error involving textlint-scripts.

❯ yarn install
yarn install v1.22.11
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
$ npm run --if-present build

> [email protected] build
> textlint-scripts build

sh: textlint-scripts: command not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.