Code Monkey home page Code Monkey logo

station-mobile's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

station-mobile's Issues

[Feature request] Add autocomplete off for address input

The address input is interpreted as a physical address so an extremely annoying tooltip appears every time. React Native inputs have the options to remove autocomplete on android phones with the autoComplete prop set to off.

Ledger authorization confused by fingerprint auth & temp workaround

Hi,

First of all, great job supporting Ledger on mobile!

I hit upon an issue that you may want to fix (workaround at bottom):

Environment

Station Mobile v1.5.4-136 on Android 11

I have a normal (non-ledger) account and a ledger account. I have bio (fingerprint) authentication enabled for the non-ledger account and this setting seems to apply app-wide when I switch wallets to the ledger one.

A prerequisite for this bug seems to be a bio-auth enabled account existing on the app, as there is no "bio-auth" setting offered in the ledger account options, but the setting seems to persist in the app settings from the other account.

Problem

When authorizing third-party ledger transactions (e.g. Anchor) with biometric auth enabled on the app, it chooses the fingerprint method to authenticate. Authorizing that way obviously doesn't work and it fails silently.

Proposed solution

It would help the UX if you detect that a currently-logged in account is hardware-wallet authed and skip biometric authentication in these cases.

Temporary workaround

To make this work on the current version you can:

  1. Tap "Sign" when your transaction opens on station mobile. You get the fingerprint auth modal instead of ledger selection screen.

  2. Tap "cancel" on the fingerprint auth screen (or hit the back button, if you have one)

  3. Tap "OK" when asked "Would you like to confirm with your password"?

  4. The Ledger selection screen appears and you can authorize properly

Alternatively, disabling bio auth on the other account(s) should also work.

Invalid hex string issue

Is there anyone here that is an expert on terra station. I desparatly need help with this invalid Hex string error. Please don't dm me as I am not going to generate a qr code for you to scam me.

Wallet balance locked to KRW, showing NaN balance

Summary

After update, station's LUNA balance is showing "NaN KRW". The currency cannot be changed to USD despite being that before the update.

Expected

Before update station was showing clear USD value.

  • OS: Oxygen OS 11.0.2.1.GM57BA

Edit:
Works fine now. USD had to be set again manually.

Account for Root Check False Positives

I made this its own issue as it has to do with how the root check works and not about it being optional.

Please see the documentation for RootBeer under False Positives:
https://github.com/scottyab/rootbeer#false-positives

Manufacturers often leave the busybox binary in production builds and this doesn't always mean that a device is root. We have removed the busybox check we used to include as standard in the isRooted() method to avoid these false positives.
The following devices are known the have the busybox binary present on the stock rom:

  • All OnePlus Devices
  • Moto E
  • OPPO R9m (ColorOS 3.0,Android 5.1,Android security patch January 5, 2018 )

As far as I understand it, it looks like the implementation is not using the recommended practice.

https://github.com/terra-money/station-mobile/blob/4dfb12a28a5b029fa2f91cae9703fce1c9d3b7fc/android/app/src/main/java/money/terra/station/UtilLib/RootChecker.kt

file: station-mobile/android/app/src/main/java/money/terra/station/UtilLib/RootChecker.kt (line 21)

RootBeer(context).let {
                if (it.isRootedWithBusyBoxCheck) {
                    promise.resolve(true)
                }
            }

I am reporting this because I have a OnePlus phone that is not Rooted and it is not allowing me to use Terra Station. See attached screenshots. There are also some negative app reviews of people who say they are not rooted but get this error.

Screenshot_20220114-175735
Screenshot_20220114-042502

I would like to say, this looks like a great app! Keep up the good work. 👍

Build Issues

Hi, I encountered several build issues in the main branch. Hopefully easy fixes for the team! Details below

  1. Invalid Podfile file: unkown keywords: "Flipper", "Flipper-Folly", "Flipper-RSocket

Screen Shot 2022-04-17 at 12 00 34 pm

  1. Merge conflicts on src/hooks/userConfim.ts

Screen Shot 2022-04-17 at 12 02 55 pm

  1. Merge conflicts on src/screens/auth/ConnectLedger/DeviceSelector.tsx

Screen Shot 2022-04-17 at 12 04 06 pm

Dark mode?

Greetings,

First to all the devs:
Thanks for all your work on this, it's really solid 🙏 .

I would really like for there to be a dark mode in the app that matches the desktop app for Mac. Is there a want for that?
Not sure if this is the right forum for this.

[Feature request] Add security check before entering the app (PIN, Fingerprint, Face ID)

I believe this wallet is missing one very important feature, which is the ability to let users add some security checks before entering the app, for example: PIN (some custom view) and Fingerprint, Face ID (native ones from Android and iOS).

If @terra-money didn't already plan on working on this feature, I would like to start on it and make a PR when done, of course, if permitted by maintainers, and would like to discuss more about some details regarding this feature.

Ledger support via USB-OTG, then ledger bluetooth support

I tried out the Terra station mobile app on android and noticed that ledger support wasn't available. Looking at this github it wasn't clear if anyone is working on adding it. Creating this as a feature request. The terra station extension supports ledger and might be portable to the android version. Let me know if I can provide any help along the way.

[BUG] some validator can't do re-delegations

[BUG] some validators can't do re-delegations

Describe the bug
some validators can't do re delegations

To Reproduce
click stake -> choose a validator choose re-delegation ->choose PFC-OSS , Orbital Command ,Terra Bites , 01node, or LUNC DAO

Context & versions
Android (App version v2.0.0-161)and web

log:failed to execute message; message index: 0: too few tokens to redelegate (truncates to zero tokens): invalid request

please publish version 1.5.4 on github

Hi,
I have 1.5.3 version installed from the github releases, but now cannot use it because it wants to be updated, and I cannot update it to google play version because of a different signature. Please release the 1.5.4 on Github!

Signbytes

I was trying to use sign bytes from the wallet provider via wallet connect but it says it's not supported. Any chance it will be added soon?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.