Code Monkey home page Code Monkey logo

comfys3's Issues

[Feature] Adding a S3_ENTPOINT environment variable.

Allowing the configuration of the Entpoint via this Variable allows the user to target use a AWS PrivateLink or any other S3 Compatible Storage Impementation.

This this shoud target the boto3 endpoint_url argument

Save to jpeg before uploading?

@TemryL I've been using the Image Save node from WAS suite to convert images to jpg and remove metadata before saving. Is there any way to use this with the save to s3 node?

image

Which to use to save 3d formats?

For video I assume things like .webp would work but if I want to save a mesh object in either .obj, .gltf etc which node would I use?

P.S. amazing project

Output directory incorrect

@TemryL In the .env, I used "output" as the output directory.

But when the file is saved, it's not saved to the "output" folder. Instead "output" is added as a prefix to the file name. What am I doing wrong?

image
image

I don't understand how your Node works...

Thanks for your previous work. However, I don't understand how your Node operates, and I really need it to work for my customer.

Here are the details of my .env file:

S3_REGION = "eu-central-1"
S3_ACCESS_KEY = "XXX"
S3_SECRET_KEY = "XXX"
S3_BUCKET_NAME = "my-great-bucket"
S3_INPUT_DIR = "test"
S3_OUTPUT_DIR = "test"

This is my workflow:
Screenshot 2024-07-26 at 17 34 02

These are the errors I'm encountering:

[2024-07-26 15:28] [ComfyS3] - �[0;31mERROR�[0m - Failed to check if folder exists in S3: 'NoneType' object has no attribute 'Bucket'
[2024-07-26 15:28] [ComfyS3] - �[0;31mERROR�[0m - Failed to create folder in S3: 'NoneType' object has no attribute 'Bucket'
[2024-07-26 15:28] [ComfyS3] - �[0;31mERROR�[0m - Failed to check if folder exists in S3: 'NoneType' object has no attribute 'Bucket'
[2024-07-26 15:28] [ComfyS3] - �[0;31mERROR�[0m - Failed to upload file to S3: 'NoneType' object has no attribute 'Bucket'
[2024-07-26 15:28] [ComfyS3] - �[0;31mERROR�[0m - Failed to upload file to S3: 'NoneType' object has no attribute 'Bucket'
[2024-07-26 15:28] [ComfyS3] - �[0;31mERROR�[0m - Failed to upload file to S3: 'NoneType' object has no attribute 'Bucket'
[2024-07-26 15:28] !!! Exception during processing!!! 'NoneType' object is not iterable

I would greatly appreciate any help with resolving this issue.

ComfyS3 node is not visible in ComfyUI

ComfyS3 node is not visible in ComfyUI after so many times restart the server and update the node from comfyui manager, what i do and one more important thing i also update the details in .env file

Add UUID subfolder to prevent overwriting?

Currently, all files are uploaded to a single output folder in s3. My output folder is called "output". But files can be overwritten when they have the same name, which is becoming frequent for me. I could add a very long random prefix to each file name, like 12312301923810923.jpg, but then the file name starts to look very long and ugly, especially since my users download their files. Is there a way to save each group of files in their own UUID subfolder to prevent overwriting?

For example, if there are 3 outputs for a single run, they would be saved to

output/550e8400-e29b-41d4-a716-446655440000/file1.jpg
output/550e8400-e29b-41d4-a716-446655440000/file2.jpg
output/550e8400-e29b-41d4-a716-446655440000/file3.jpg

Each subsequent run, the UUID subfolder would change.

Currently, the output names look like this.

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.