same skb is added to the msg's skb_list multiple times in ss_tcp_process_skb() about tempesta HOT 5 CLOSED

Eventually, ss_skb_queue_tail() is called in all cases, and it has protection from a double insertion. If an SKB in on the list already, then it's not put there again.

This sort of design might be questionable, but that's a totally different topic. The bug does not exist as described.

from tempesta.

This is poor design of put_skb_to_msg(), must be fixed. There is no sense to call the hook many times just to see that the skb is already in the list.

from tempesta.

It appears that the fix is not complete. When the message is postponed - and that the usual course of action as an skb is processed in chunks - tfw_connection_postpone_skb() attempts to add the skb to the message's skb_list again. Always.

from tempesta.

Ok, please do the fix.

from tempesta.

The rest of this issue is moved to #80.

from tempesta.