Code Monkey home page Code Monkey logo

Comments (4)

krizhanovsky avatar krizhanovsky commented on August 10, 2024

It seems this is a Burp issue. I retried the request with curl:

curl -i -v -k --http2 -H 'Content-Length: 9' -X POST --data 'abcd=dgdfGET /n HTTP/1.1\r\nHost: 02.rs?x.netflix.com\r\nFoo: bar' https://tempesta-tech.com

and I got

HTTP/2 400 
date: Sat, 18 May 2024 21:56:15 GMT
content-length: 0
server: Tempesta FW/0.8.0

with Warning: Request parsing inconsistency: 192.168.100.1 in log.

from tempesta.

krizhanovsky avatar krizhanovsky commented on August 10, 2024

OK, it seems we're good and do not pass any of the attack samples (I was playing with Burp and curl for the whole evening), but it's still worth checking our test suite for the attack samples and implement them in case of further regressions.

I'd be cool if you could break our protection against request smuggling attack.

Also please investigate the issue with Burp: maybe it was just a misuse on my side or the tool or Tempesta have some framing (I suppose) bug. If so then, the bug should be revealed and reported.

from tempesta.

krizhanovsky avatar krizhanovsky commented on August 10, 2024

On this screenshot Burp hangs in waiting for a response. Maybe there is a problem with the showing HTTP/2 as HTTP/1 feature...

image

from tempesta.

const-t avatar const-t commented on August 10, 2024

tfw_h2_parse_body() function does print Content-Length for debugging, but does not validate it against the actual DATA length. I played with varying the data length, but didn't succeed on request smuggling.

Looks like END_STREAM was not received. When END_STREAM is received tfw_h2_parse_req_finish() validates Content-Length against actual body length(total size of DATA frames), while END_STREAM not received Tempesta just waits next frame.

from tempesta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.