Comments (8)
@ksmithut In my opinion it should no longer be logged at all, as a warn
or otherwise, since it is now a "normal" event that isn't indicative of any problem or out-of-the-ordinary situation. See: https://github.com/tellnes/bunyan-middleware/pull/22/files
from bunyan-middleware.
I opened that PR 2 weeks ago now, and no sign of any activity from the project owner 🤔
from bunyan-middleware.
I am seeing these warnings as well
Node: 10.2.1
express: 4.16.3
bunyan-middleware: 0.8.0
from bunyan-middleware.
Downgrading to Node 8.9.4 seems to disappear the warning. I will continue to investigate
from bunyan-middleware.
Is the root cause
from bunyan-middleware.
So if that's the correct behavior for the 'close' event to be emitted always, perhaps this log shouldn't be a warn
? or is it also indicative of warn
behavior?
from bunyan-middleware.
@msmol I would agree, I should have looked at the existing PRs 👍
from bunyan-middleware.
Merged the pull request, so closing this.
from bunyan-middleware.
Related Issues (12)
- refactored completely your project HOT 9
- replace 'node-uuid' with 'uuid' HOT 1
- Reasoning behind switching from UUID v4 to UUID v1? HOT 3
- Verbose: false, still logs "request finish" HOT 4
- Plan for 1.0.0 release? HOT 2
- Is this package working? HOT 1
- TypeScript: no default export HOT 1
- Feature Request: Log request information in "start request" log message HOT 2
- it should apply header filter for response as well HOT 1
- Feat: Option to include headers HOT 1
- Removing obsureHeaders from log at all HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bunyan-middleware.