refactored completely your project about bunyan-middleware HOT 9 CLOSED

Cool.

As far as I can see is the difference your duration property. I will probably implement that myself since it is a good ide.

Also, you have a much better readme. I'll accept pull requests.

from bunyan-middleware.

I pushed a few commits. Some of them is thing inspired by your version while others is thing I have thought about some time.

from bunyan-middleware.

nice, I think our two modules are too different now. thanks. I kept your license

from bunyan-middleware.

What was your reason to switch to uuid v4 instead of v1?

from bunyan-middleware.

No particular reason, I always use v4 uuids. Do you have any reason to use v1 or v4?

from bunyan-middleware.

No. That is why I did ask so you maybe would give me one.

from bunyan-middleware.

After reading Which UUID version to use? on stackoverflow I think I will change it to v4. The reason is that we are reading the ID from the incoming headers and that make it easy for someone to manipulate the logs.

I think it maybe should be configurable and disabled by default. But it is a nice feature if you are using a proxy server which gennerates request ids.

What do you think?

from bunyan-middleware.

Also, I see that you have done some work on npm uuid and switched to that. Is npm node-uuid dead?

from bunyan-middleware.

In a real environment the uuid would maybe be generated by the highest server in your stack (nginx) and then forwarded. But nginx should not read the uuid from the client. Thus you can't get hacked on this.

As for the feature I don't know. I tried to have the smallest feature list.

node-uuid is not dead it's just that uuid is the first one you find on npmjs by default. And uuid seems more uptodate.

I only modified uuid to be more easy to use on browser.

from bunyan-middleware.