telia-oss / terraform-aws-lambda Goto Github PK

Bug report

Cannot use module without setting the environement variable.
environement is marked as an optional field in the documentation.

The module only works if environement is set with at least one actual variable.
Can not be set as null or an empty object.

Steps to reproduce

Create a new module without environment set.

module "main" {
  source = "telia-oss/lambda/aws"
  version = "3.1.0"

  name_prefix = "hello-world"
  policy = data.aws_iam_policy_document.main.json

  s3_bucket = "my-bucket"
  s3_key = "my-function.zip"

  handler = "handler.handler"
  runtime = "nodejs12.x"
}

Terraform version

$ terraform version

Terraform v0.14.5
+ provider registry.terraform.io/hashicorp/aws v3.25.0

Error message in title. This seems to be caused by:

• hashicorp/terraform#10900
• hashicorp/terraform-provider-aws#443

Versions:

• terraform: v0.11.7
• aws provider: v1.25.0

Not all Lambdas need to access AWS resources.

Issue

When you trying to create basic lambda function using this template it failed with error Failed getting S3 object: InvalidParameter: 2 validation error(s) found. This issue is causing by aws_s3_bucket_object which terraform trying to define in every kind of lambdas.

Versions

Terraform v0.11.11 + provider.aws v2.6.0

Step to reproduce

Provision basic lambda (without VPC or S3) using a default example at folder examples/default

$ terraform init
Initializing modules...
- module.lambda
Initializing provider plugins...
Terraform has been successfully initialized!

$ terraform plan
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

data.aws_s3_bucket_object.main: Refreshing state...
data.aws_iam_policy_document.assume: Refreshing state...
data.aws_iam_policy_document.lambda: Refreshing state...

Error: Error refreshing state: 1 error(s) occurred:

* module.lambda.data.aws_s3_bucket_object.main: 1 error(s) occurred:

* module.lambda.data.aws_s3_bucket_object.main: data.aws_s3_bucket_object.main: Failed getting S3 object: InvalidParameter: 2 validation error(s) found.
- minimum field size of 1, HeadObjectInput.Bucket.
- minimum field size of 1, HeadObjectInput.Key.
 Bucket: "" Object: ""

Fix

A possible way how to fix the issue can be added the count meta-argument to the aws_s3_bucket_object main object as well.

https://github.com/telia-oss/terraform-aws-lambda/blob/0.3.4/main.tf#L67

data "aws_s3_bucket_object" "main" {
  count  = "${var.filename == "" ? 1 : 0}"
  bucket = "${var.s3_bucket}"
  key    = "${var.s3_key}"
}