telia-oss / terraform-aws-grafana Goto Github PK

Chain new versions of grafana and aws-env to publish docker images automatically.

Arguably the VPC should be defined outside the module so that Grafana can be deployed to an existing VPC. As such, the VPC should be removed.

Feature request

How can we improve the module?
Hi guys,
First of all, thanks for this!
I hhave tried to update to the newest version of grafana, however I've have received the following error:
"lvl=eror msg="Server shutdown" logger=server reason="Service init failed: Migration failed err: dial tcp: address tcp////grafana/rds-url: unknown port"
I've changed the grafana rds host value to: value = "${module.grafana_rds.endpoint}:${module.grafana_rds.port}"
But it did not make any difference. Also tried lots of ways, but did not work.
Do you guys have any suggestion how can I make this work?
Cheers

The issue telia-oss/terraform-aws-sonarqube#4 is probably also a problem for this repo

ECS now supports specifying secrets (stored in SSM or SM) directly without needing aws-env. This makes it a lot easier to use pre-existing grafana docker images since we don't need to include aws-env.

While we are at it, we should also remove the SSM data source usage from the modules since:

• Most of the values are not secrets and might as well be hardcoded in the task definition.
• People should be free to use secrets manager for the things that are actually secrets, if they want to.

With the above in place I think we should also consider removing the init module.